Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8511045: Cleanup: Remove unneeded forward declarations in base, dbug, gpu, ipc, jingle, and media. (Closed)

Created:
9 years, 1 month ago by Lei Zhang
Modified:
9 years, 1 month ago
CC:
chromium-reviews, hclam+watch_chromium.org, sadrul, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, ajwong+watch_chromium.org, jam, annacc+watch_chromium.org, apatrick_chromium, pam+watch_chromium.org, brettw-cc_chromium.org, vrk (LEFT CHROMIUM), darin-cc_chromium.org, scherkus (not reviewing), ihf+watch_chromium.org
Visibility:
Public.

Description

Cleanup: Remove unneeded forward declarations in base, dbug, gpu, ipc, jingle, and media. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109998

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -50 lines) Patch
M base/debug/trace_event_win.h View 1 chunk +1 line, -4 lines 0 comments Download
M base/message_loop.h View 2 chunks +2 lines, -6 lines 0 comments Download
M dbus/exported_object.h View 1 chunk +3 lines, -5 lines 0 comments Download
M dbus/object_proxy.h View 1 chunk +2 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/tools/compositor_model_bench/shaders.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ipc/ipc_sync_channel.h View 3 chunks +3 lines, -4 lines 0 comments Download
M ipc/ipc_sync_message_filter.h View 2 chunks +2 lines, -3 lines 0 comments Download
M jingle/notifier/base/resolving_client_socket_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M jingle/notifier/base/xmpp_client_socket_factory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M jingle/notifier/communicator/login.h View 1 chunk +0 lines, -1 line 0 comments Download
M jingle/notifier/communicator/login_settings.h View 1 chunk +0 lines, -4 lines 0 comments Download
M jingle/notifier/communicator/xmpp_connection_generator.h View 1 chunk +0 lines, -5 lines 0 comments Download
M media/audio/mac/audio_manager_mac.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/audio/win/audio_manager_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/demuxer_stream.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_demuxer.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
owner: directory thakis: base, dbus piman: gpu jam: ipc ajwong: jingle scherkus: media
9 years, 1 month ago (2011-11-11 01:54:15 UTC) #1
piman
lgtm
9 years, 1 month ago (2011-11-11 01:55:21 UTC) #2
scherkus (not reviewing)
*hot* media LGTM
9 years, 1 month ago (2011-11-11 02:06:49 UTC) #3
jam
ipc lgtm
9 years, 1 month ago (2011-11-11 03:05:50 UTC) #4
Nico
9 years, 1 month ago (2011-11-11 05:22:56 UTC) #5 
base, dbus lgtm

Out of interest, how did you find this?

Powered by Google App Engine
This is Rietveld 408576698