GTK: Use IDR_THEME_WINDOW_CONTROL_BACKGROUND when drawing min/max/close and new tab buttons.

GTK: Use IDR_THEME_WINDOW_CONTROL_BACKGROUND when drawing min/max/close and new tab buttons.

This matches windows behaviour and makes the buttons visible in several themes.

BUG=103661
TEST=Install Puk-Puk; Close button should have solid background, even when over part of the design on the skyline.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109566

[Elliot Glaysher, 2011-11-10 00:54:10]

estade: review
mirandac: fyi

http://codereview.chromium.org/8511041/diff/1/chrome/browser/ui/gtk/gtk_theme...
File chrome/browser/ui/gtk/gtk_theme_service.cc (left):

http://codereview.chromium.org/8511041/diff/1/chrome/browser/ui/gtk/gtk_theme...
chrome/browser/ui/gtk/gtk_theme_service.cc:756:
SetThemeColorFromGtk(ThemeService::COLOR_BUTTON_BACKGROUND,
This call is simply wrong. It should be transparent unless explicitly overridden
by a theme.

[Evan Stade, 2011-11-11 00:09:15]

lgtm

http://codereview.chromium.org/8511041/diff/2001/chrome/browser/ui/gtk/browse...
File chrome/browser/ui/gtk/browser_titlebar.cc (right):

http://codereview.chromium.org/8511041/diff/2001/chrome/browser/ui/gtk/browse...
chrome/browser/ui/gtk/browser_titlebar.cc:559: // aways with this in the short
term because our buttons are rectangles. We
away

http://codereview.chromium.org/8511041/diff/2001/chrome/browser/ui/gtk/browse...
chrome/browser/ui/gtk/browser_titlebar.cc:561: // masks. http://crbug.com/103661
"masks that match our masks" -- could you reword this to be more clear

[commit-bot: I haz the power, 2011-11-11 00:32:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/8511041/5001

[commit-bot: I haz the power, 2011-11-11 02:31:58]

Change committed as 109566