Issue 8511034: uint32_t -> uint32 in content/browser/plugin_loader_posix.* and include basictypes.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8511034: uint32_t -> uint32 in content/browser/plugin_loader_posix.* and include basictypes.h. (Closed)

Created:
9 years, 1 month ago by viettrungluu

Modified:
9 years, 1 month ago

Reviewers:
Robert Sesek, sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., jam, dpranke-watch+content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

uint32_t -> uint32 in content/browser/plugin_loader_posix.* and include basictypes.h. The header file currently doesn't compile on Windows (unless a definition for uint32_t is picked up from elsewhere, coincidentally). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109329

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -6 lines)			Patch
M	content/browser/plugin_loader_posix.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	content/browser/plugin_loader_posix.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/plugin_loader_posix_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

9 years, 1 month ago (2011-11-12 22:26:41 UTC) #3

Why is this file getting compiled on Windows? _posix should be excluded.

Expand Messages | Collapse Messages