chrome/browser/chromeos/accessibility_util.cc - Issue 8511026: Don't start speech synthesis until after the audio mixer is initialized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/accessibility_util.cc

Issue 8511026: Don't start speech synthesis until after the audio mixer is initialized. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/accessibility_util.cc

===================================================================

--- chrome/browser/chromeos/accessibility_util.cc (revision 109026)

+++ chrome/browser/chromeos/accessibility_util.cc (working copy)

@@ -8,9 +8,8 @@

#include "base/bind_helpers.h"

#include "base/logging.h"

#include "chrome/browser/browser_process.h"

-#include "chrome/browser/chromeos/dbus/dbus_thread_manager.h"

-#include "chrome/browser/chromeos/dbus/speech_synthesizer_client.h"

#include "chrome/browser/extensions/extension_accessibility_api.h"

+#include "chrome/browser/extensions/extension_tts_api_platform.h"

#include "chrome/browser/extensions/component_loader.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/file_reader.h"

@@ -150,17 +149,12 @@

};

void Speak(const char* speak_str, bool queue, bool interruptible) {

oshima 2011/11/09 23:47:32 are "queue" and "interruptable" parameters obsolet

dmazzoni 2011/11/10 07:19:57 Done. They're obsolete assuming that the old views

- if (queue || !interruptible) {

- std::string props = "";

- props.append("enqueue=");

- props.append(queue ? "1;" : "0;");

- props.append("interruptible=");

- props.append(interruptible ? "1;" : "0;");

- chromeos::DBusThreadManager::Get()->GetSpeechSynthesizerClient()->

- SetSpeakProperties(props);

- }

- chromeos::DBusThreadManager::Get()->GetSpeechSynthesizerClient()->

- Speak(speak_str);

+ UtteranceContinuousParameters params;

+ ExtensionTtsPlatformImpl::GetInstance()->Speak(

+ -1,

+ speak_str,

+ "",

+ params);

oshima 2011/11/09 23:47:32 can you add comment for -1 and ""? (like -1 /* xy

dmazzoni 2011/11/10 07:19:57 Done. Actually the "" should have been the languag

}

« no previous file with comments | « no previous file | chrome/browser/chromeos/audio_mixer_alsa.cc » ('j') | chrome/browser/extensions/extension_tts_api_chromeos.cc » ('J')