Don't start speech synthesis until after the audio mixer is initialized.

Don't start speech synthesis until after the audio mixer is initialized.

Merges all Chrome OS audio code to use a single codepath, and
notify the TTS interface when the audio mixer is initialized so
that any queued speech can be played at that time.

BUG=103629
BUG=chromium-os:19067
TEST=No visible change yet; this will make it possible to eliminate the 3-second startup delay for speech synthesis.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109548

[oshima, 2011-11-09 23:47:32]

http://codereview.chromium.org/8511026/diff/1/chrome/browser/chromeos/accessi...
File chrome/browser/chromeos/accessibility_util.cc (right):

http://codereview.chromium.org/8511026/diff/1/chrome/browser/chromeos/accessi...
chrome/browser/chromeos/accessibility_util.cc:151: void Speak(const char*
speak_str, bool queue, bool interruptible) {
are "queue" and "interruptable" parameters obsolete?
If so, can we remove them?

http://codereview.chromium.org/8511026/diff/1/chrome/browser/chromeos/accessi...
chrome/browser/chromeos/accessibility_util.cc:157: params);
can you add comment for -1 and ""? 
(like -1 /* xyz */)

http://codereview.chromium.org/8511026/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_tts_api_chromeos.cc (right):

http://codereview.chromium.org/8511026/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_tts_api_chromeos.cc:14: #include
"chrome/browser/extensions/extension_tts_api_chromeos.h"
move this to top.

http://codereview.chromium.org/8511026/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_tts_api_chromeos.cc:158: while
(!queued_utterances_.empty()) {
STLDeleteContainerPointers?

[dmazzoni, 2011-11-10 07:19:57]

http://codereview.chromium.org/8511026/diff/1/chrome/browser/chromeos/accessi...
File chrome/browser/chromeos/accessibility_util.cc (right):

http://codereview.chromium.org/8511026/diff/1/chrome/browser/chromeos/accessi...
chrome/browser/chromeos/accessibility_util.cc:151: void Speak(const char*
speak_str, bool queue, bool interruptible) {
On 2011/11/09 23:47:32, oshima wrote:
> are "queue" and "interruptable" parameters obsolete?
> If so, can we remove them?

Done. They're obsolete assuming that the old views-based oobe/login is obsolete.
Is there a plan to get rid of it soon?

http://codereview.chromium.org/8511026/diff/1/chrome/browser/chromeos/accessi...
chrome/browser/chromeos/accessibility_util.cc:157: params);
On 2011/11/09 23:47:32, oshima wrote:
> can you add comment for -1 and ""? 
> (like -1 /* xyz */)

Done. Actually the "" should have been the language/locale, I fixed that. (""
just gave the default.)

http://codereview.chromium.org/8511026/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_tts_api_chromeos.cc (right):

http://codereview.chromium.org/8511026/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_tts_api_chromeos.cc:14: #include
"chrome/browser/extensions/extension_tts_api_chromeos.h"
On 2011/11/09 23:47:32, oshima wrote:
> move this to top.

Done.

http://codereview.chromium.org/8511026/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_tts_api_chromeos.cc:158: while
(!queued_utterances_.empty()) {
On 2011/11/09 23:47:32, oshima wrote:
> STLDeleteContainerPointers?

Good idea, I used STLDeleteElements.

[oshima, 2011-11-10 16:42:14]

FYI: http://code.google.com/p/chromium/issues/detail?id=99545#c9

http://codereview.chromium.org/8511026/diff/5002/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_tts_api_chromeos.cc (right):

http://codereview.chromium.org/8511026/diff/5002/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_tts_api_chromeos.cc:160:
STLDeleteElements(&queued_utterances_);
you need to clear the queue, i guess?

[dmazzoni, 2011-11-10 17:05:57]

http://codereview.chromium.org/8511026/diff/5002/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_tts_api_chromeos.cc (right):

http://codereview.chromium.org/8511026/diff/5002/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_tts_api_chromeos.cc:160:
STLDeleteElements(&queued_utterances_);
On 2011/11/10 16:42:15, oshima wrote:
> you need to clear the queue, i guess?

Yes, STLDeleteElements deletes the elements and clears the queue. 
STLDeleteContainerPointers does not.

[oshima, 2011-11-10 17:09:56]

On Thu, Nov 10, 2011 at 9:05 AM, <dmazzoni@chromium.org> wrote:

>
> http://codereview.chromium.**org/8511026/diff/5002/chrome/**
>
browser/extensions/extension_**tts_api_chromeos.cc<http://codereview.chromium.org/8511026/diff/5002/chrome/browser/extensions/extension_tts_api_chromeos.cc>
> File chrome/browser/extensions/**extension_tts_api_chromeos.cc (right):
>
> http://codereview.chromium.**org/8511026/diff/5002/chrome/**
>
browser/extensions/extension_**tts_api_chromeos.cc#newcode160<http://codereview.chromium.org/8511026/diff/5002/chrome/browser/extensions/extension_tts_api_chromeos.cc#newcode160>
> chrome/browser/extensions/**extension_tts_api_chromeos.cc:**160:
> STLDeleteElements(&queued_**utterances_);
> On 2011/11/10 16:42:15, oshima wrote:
>
>> you need to clear the queue, i guess?
>>
>
> Yes, STLDeleteElements deletes the elements and clears the queue.
> STLDeleteContainerPointers does not.
>
>

ah, yes, sorry for pointing wrong function.

>
http://codereview.chromium.**org/8511026/<http://codereview.chromium.org/8511...
>

[oshima, 2011-11-10 17:19:18]

LGTM

[commit-bot: I haz the power, 2011-11-10 22:59:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/8511026/11001

[commit-bot: I haz the power, 2011-11-11 00:42:18]

Change committed as 109548