Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 8511004: Fix to correctly set accessible state of StatusAreaBubbleContentView (Closed)

Created:
9 years, 1 month ago by hashimoto
Modified:
9 years, 1 month ago
Reviewers:
stevenjb, dmazzoni
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Fix to correctly set accessible state of StatusAreaBubbleContentView BUG=chromium-os:22051 TEST=Enable spoken feedback and focus on battery icon on the status area. Press down arrow key twice and ensure that it speaks "Charging Battery full" or something like that. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110033

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/chromeos/status/status_area_bubble.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/status/status_area_bubble.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hashimoto
This patch will take effect only after the CL in http://codereview.chromium.org/8511003/
9 years, 1 month ago (2011-11-09 10:00:10 UTC) #1
dmazzoni
lgtm
9 years, 1 month ago (2011-11-09 14:39:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/8511004/1
9 years, 1 month ago (2011-11-13 15:48:12 UTC) #3
commit-bot: I haz the power
Presubmit check for 8511004-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 1 month ago (2011-11-13 15:48:16 UTC) #4
hashimoto
stevenjb, Could you review this patch as an OWNER? On 2011/11/13 15:48:16, I haz the ...
9 years, 1 month ago (2011-11-14 04:32:26 UTC) #5
stevenjb
lgtm
9 years, 1 month ago (2011-11-14 23:51:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/8511004/1
9 years, 1 month ago (2011-11-15 02:24:58 UTC) #7
commit-bot: I haz the power
9 years, 1 month ago (2011-11-15 03:41:08 UTC) #8
Change committed as 110033

Powered by Google App Engine
This is Rietveld 408576698