Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: views/controls/menu/menu_item_view.h

Issue 8511003: Fix to correctly set accessible name of menu item when there is only one child and title is empty (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changed the method name from FirstChildTakesOver to IsContainer Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | views/controls/menu/menu_item_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/controls/menu/menu_item_view.h
diff --git a/views/controls/menu/menu_item_view.h b/views/controls/menu/menu_item_view.h
index 85868851091c35d910f12ea7e1522f6eda629bf0..4111d81c4acb06ba1fd1a5325317f82e97d50e39 100644
--- a/views/controls/menu/menu_item_view.h
+++ b/views/controls/menu/menu_item_view.h
@@ -393,6 +393,10 @@ class VIEWS_EXPORT MenuItemView : public View {
void set_controller(MenuController* controller) { controller_ = controller; }
+ // Returns true if this MenuItemView contains a single child
+ // that is responsible for rendering the content.
+ bool IsContainer() const;
+
// The delegate. This is only valid for the root menu item. You shouldn't
// use this directly, instead use GetDelegate() which walks the tree as
// as necessary.
@@ -423,9 +427,6 @@ class VIEWS_EXPORT MenuItemView : public View {
// Title.
string16 title_;
- // Accessible name (doesn't include accelerators, etc.).
- string16 accessible_name_;
-
// Icon.
SkBitmap icon_;
« no previous file with comments | « no previous file | views/controls/menu/menu_item_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698