Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: views/controls/menu/menu_item_view.h

Issue 8511003: Fix to correctly set accessible name of menu item when there is only one child and title is empty (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changed the method name from IsFirstChildToTakeOver from FirstChildTakesOver Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | views/controls/menu/menu_item_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/controls/menu/menu_item_view.h
diff --git a/views/controls/menu/menu_item_view.h b/views/controls/menu/menu_item_view.h
index 85868851091c35d910f12ea7e1522f6eda629bf0..47298ee58b4485d402561f1a518a161e33d88c55 100644
--- a/views/controls/menu/menu_item_view.h
+++ b/views/controls/menu/menu_item_view.h
@@ -393,6 +393,11 @@ class VIEWS_EXPORT MenuItemView : public View {
void set_controller(MenuController* controller) { controller_ = controller; }
+ // Returns true when |this| itself has no content and the first child is
+ // responsible for showing content.
+ // (i.e. when the label is empty and there is only one child.)
+ bool FirstChildTakesOver() const;
sky 2011/11/10 15:58:48 This name is confusing. How about IsContainer with
hashimoto 2011/11/11 05:30:45 Done.
+
// The delegate. This is only valid for the root menu item. You shouldn't
// use this directly, instead use GetDelegate() which walks the tree as
// as necessary.
@@ -423,9 +428,6 @@ class VIEWS_EXPORT MenuItemView : public View {
// Title.
string16 title_;
- // Accessible name (doesn't include accelerators, etc.).
- string16 accessible_name_;
-
// Icon.
SkBitmap icon_;
« no previous file with comments | « no previous file | views/controls/menu/menu_item_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698