Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: chrome/browser/sync/engine/process_commit_response_command.h

Issue 8510079: sync: Remove ModelNeutralExecuteImpl() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix bug that caused integration test failures Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/process_commit_response_command.h
diff --git a/chrome/browser/sync/engine/process_commit_response_command.h b/chrome/browser/sync/engine/process_commit_response_command.h
index dbba580d58928e3a15f1361edced1a8016a83c61..a2f4430e9ec55314233479f3d5125501d75123ca 100644
--- a/chrome/browser/sync/engine/process_commit_response_command.h
+++ b/chrome/browser/sync/engine/process_commit_response_command.h
@@ -27,11 +27,16 @@ class ProcessCommitResponseCommand : public ModelChangingSyncerCommand {
ProcessCommitResponseCommand();
virtual ~ProcessCommitResponseCommand();
+ // Override part of ModelChangingSyncerCommand's SyncerCommand implementation
+ virtual void ExecuteImpl(sessions::SyncSession*);
+
// ModelChangingSyncerCommand implementation.
- virtual bool ModelNeutralExecuteImpl(sessions::SyncSession* session);
virtual void ModelChangingExecuteImpl(sessions::SyncSession* session);
private:
+ // Returns true if these updates should not be processed.
+ bool ModelNeutralShouldExitEarly(sessions::SyncSession* session);
+
CommitResponse::ResponseType ProcessSingleCommitResponse(
syncable::WriteTransaction* trans,
const sync_pb::CommitResponse_EntryResponse& pb_commit_response,

Powered by Google App Engine
This is Rietveld 408576698