Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: chrome/browser/sync/engine/process_updates_command.h

Issue 8510079: sync: Remove ModelNeutralExecuteImpl() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix bug that caused integration test failures Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_ 5 #ifndef CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_
6 #define CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_ 6 #define CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_
7 #pragma once 7 #pragma once
8 8
9 #include "chrome/browser/sync/engine/model_changing_syncer_command.h" 9 #include "chrome/browser/sync/engine/model_changing_syncer_command.h"
10 #include "chrome/browser/sync/engine/syncer_types.h" 10 #include "chrome/browser/sync/engine/syncer_types.h"
(...skipping 16 matching lines...) Expand all
27 // 27 //
28 // Postconditions - All of the verified SyncEntity data will be copied to 28 // Postconditions - All of the verified SyncEntity data will be copied to
29 // the server fields of the corresponding syncable entries. 29 // the server fields of the corresponding syncable entries.
30 // TODO(tim): This should not be ModelChanging (bug 36592). 30 // TODO(tim): This should not be ModelChanging (bug 36592).
31 class ProcessUpdatesCommand : public ModelChangingSyncerCommand { 31 class ProcessUpdatesCommand : public ModelChangingSyncerCommand {
32 public: 32 public:
33 ProcessUpdatesCommand(); 33 ProcessUpdatesCommand();
34 virtual ~ProcessUpdatesCommand(); 34 virtual ~ProcessUpdatesCommand();
35 35
36 // ModelChangingSyncerCommand implementation. 36 // ModelChangingSyncerCommand implementation.
37 virtual bool ModelNeutralExecuteImpl(sessions::SyncSession* session);
38 virtual void ModelChangingExecuteImpl(sessions::SyncSession* session); 37 virtual void ModelChangingExecuteImpl(sessions::SyncSession* session);
39 38
40 private: 39 private:
41 ServerUpdateProcessingResult ProcessUpdate( 40 ServerUpdateProcessingResult ProcessUpdate(
42 const syncable::ScopedDirLookup& dir, 41 const syncable::ScopedDirLookup& dir,
43 const sync_pb::SyncEntity& proto_update, 42 const sync_pb::SyncEntity& proto_update,
44 syncable::WriteTransaction* const trans); 43 syncable::WriteTransaction* const trans);
45 DISALLOW_COPY_AND_ASSIGN(ProcessUpdatesCommand); 44 DISALLOW_COPY_AND_ASSIGN(ProcessUpdatesCommand);
46 }; 45 };
47 46
48 } // namespace browser_sync 47 } // namespace browser_sync
49 48
50 #endif // CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_ 49 #endif // CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_
OLDNEW
« no previous file with comments | « chrome/browser/sync/engine/process_commit_response_command.cc ('k') | chrome/browser/sync/engine/process_updates_command.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698