sync: Remove ModelNeutralExecuteImpl()

chrome/browser/sync/engine/syncer.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/engine/syncer.h"
 
 #include "base/location.h"
 #include "base/message_loop.h"
 #include "base/time.h"
 #include "chrome/browser/sync/engine/apply_updates_command.h"
@@ skipping 125 matching lines @@
       }
       case VERIFY_UPDATES: {
         VLOG(1) << "Verifying Updates";
         VerifyUpdatesCommand verify_updates;
         verify_updates.Execute(session);
         next_step = PROCESS_UPDATES;
         break;
       }
       case PROCESS_UPDATES: {
         VLOG(1) << "Processing Updates";
-        ProcessUpdatesCommand process_updates;
-        process_updates.Execute(session);
+        if (session->status_controller()->ResponseContainsUpdates()) {

[tim (not reviewing), 2011/11/17 18:46:38]

I like this but the pattern here is typically to figure out next_step before
transitioning, as you'd draw it in a state diagram.  I can see arguments for
doing it this way (happens regardless of path taken to get here, consistent with
the previous implementation).

I'm curious where you're going though... could you provide any info on how this
helps you with the next piece?

+          ProcessUpdatesCommand process_updates;
+          process_updates.Execute(session);
+        }
         next_step = STORE_TIMESTAMPS;
         break;
       }
       case STORE_TIMESTAMPS: {
         VLOG(1) << "Storing timestamps";
         StoreTimestampsCommand store_timestamps;
         store_timestamps.Execute(session);
         // We should download all of the updates before attempting to process
         // them.
         if (session->status_controller()->ServerSaysNothingMoreToDownload() ||
@@ skipping 190 matching lines @@
   entry->Put(SERVER_CTIME, Time());
   entry->Put(SERVER_VERSION, 0);
   entry->Put(SERVER_IS_DIR, false);
   entry->Put(SERVER_IS_DEL, false);
   entry->Put(IS_UNAPPLIED_UPDATE, false);
   entry->Put(SERVER_SPECIFICS, sync_pb::EntitySpecifics::default_instance());
   entry->Put(SERVER_POSITION_IN_PARENT, 0);
 }
 
 }  // namespace browser_sync