Issue 8510078: checkboxes css: remove :active funkiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8510078: checkboxes css: remove :active funkiness (Closed)

Created:
9 years, 1 month ago by Evan Stade

Modified:
9 years, 1 month ago

Reviewers:
dpapad

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

checkboxes css: remove :active funkiness :hover rules were more specific than :active rules, so I had to add :not(:active) also, removed padding-before and after (no idea what that was intended to do but it made the checkmark jiggle around) BUG=103688 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110146

Patch Set 1 #

Patch Set 2 : --- #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/resources/shared/css/checkbox.css	View		3 chunks	+4 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dpapad

LGTM with nit. http://codereview.chromium.org/8510078/diff/2001/chrome/browser/resources/shared/css/checkbox.css File chrome/browser/resources/shared/css/checkbox.css (right): http://codereview.chromium.org/8510078/diff/2001/chrome/browser/resources/shared/css/checkbox.css#newcode38 chrome/browser/resources/shared/css/checkbox.css:38: /* Remove commented out rules?

9 years, 1 month ago (2011-11-15 16:47:24 UTC) #2

Evan Stade

9 years, 1 month ago (2011-11-15 17:54:35 UTC) #3

http://codereview.chromium.org/8510078/diff/2001/chrome/browser/resources/sha...
File chrome/browser/resources/shared/css/checkbox.css (right):

http://codereview.chromium.org/8510078/diff/2001/chrome/browser/resources/sha...
chrome/browser/resources/shared/css/checkbox.css:38: /*
On 2011/11/15 16:47:24, dpapad wrote:
> Remove commented out rules?

ah. Of course.

Expand Messages | Collapse Messages