Issue 8510071: Revert 109984 - Tests for WebUI Hung Renderer Dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8510071: Revert 109984 - Tests for WebUI Hung Renderer Dialog (Closed)

Created:
9 years, 1 month ago by kmadhusu

Modified:
9 years, 1 month ago

Reviewers:
wyck

CC:
chromium-reviews, arv (Not doing code reviews), Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 109984 - Tests for WebUI Hung Renderer Dialog Adds a WebUIBrowserTest for WebUI Hung Renderer Dialog. Also modifies HungRendererDialog to allow it to be called in a test without killing processes or restarting hang timers. See previous attempt: http://codereview.chromium.org/8372042 See revert of that attempt: http://codereview.chromium.org/8497001/ BUG=102073 TEST=browser_tests HungRendererDialogUITest.* Review URL: http://codereview.chromium.org/8462015 TBR=wyck@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109989

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -213 lines)			Patch
M	chrome/browser/resources/hung_renderer_dialog.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
MM	chrome/browser/ui/webui/hung_renderer_dialog.h	View	3 chunks	+1 line, -35 lines	0 comments	Download
M	chrome/browser/ui/webui/hung_renderer_dialog.cc	View	6 chunks	+26 lines, -58 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	chrome/test/data/webui/hung_renderer_dialog_test.js	View	1 chunk	+0 lines, -63 lines	0 comments	Download
D	chrome/test/data/webui/hung_renderer_dialog_ui_test-inl.h	View	1 chunk	+0 lines, -53 lines	0 comments	Download

Total messages: 1 (0 generated)