Make ProfileImageDownloader available to non-chromeos code

chrome/browser/gaia_userinfo/profile_downloader_delegate.h

Index: chrome/browser/gaia_userinfo/profile_downloader_delegate.h
diff --git a/chrome/browser/gaia_userinfo/profile_downloader_delegate.h b/chrome/browser/gaia_userinfo/profile_downloader_delegate.h
new file mode 100644
index 0000000000000000000000000000000000000000..ddcc52b4ce1ee4d6c1e9d286bd4d44265d23b9f4
--- /dev/null
+++ b/chrome/browser/gaia_userinfo/profile_downloader_delegate.h
@@ -0,0 +1,41 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_GAIA_USERINFO_PROFILE_DOWNLOADER_DELEGATE_H_
+#define CHROME_BROWSER_GAIA_USERINFO_PROFILE_DOWNLOADER_DELEGATE_H_
+#pragma once
+
+#include "base/basictypes.h"
+
+class SkBitmap;
+class Profile;
+
+// Reports on success or failure of Profile download. It is OK to delete the
+// |ProfileImageDownloader| instance in any of these handlers.
+class ProfileDownloaderDelegate {
+ public:
+  virtual ~ProfileDownloaderDelegate() {}
+
+  // Returns the desierd size of the profile image.

[Ivan Korotkov, 2011/11/15 11:05:08]

desired
If 0, returns image of the originally uploaded size.

[sail, 2011/11/15 20:17:22]

Fixed
Currently this isn't implemented. Mind if we implement this later?

[Ivan Korotkov, 2011/11/17 08:37:12]

It is implemented by Picasa :) /s0/ in URL will return the original image.

[sail, 2011/11/21 22:01:00]

Done.

+  virtual int GetDesiredImageSize() = 0;
+
+  // Returns the signed in user's user name.
+  virtual std::string GetProfileUserName() = 0;

[Ivan Korotkov, 2011/11/15 11:05:08]

AFAIK this is only used to check that logged_in_user.email() != "" (which means
guest login) and not related to any profile logic. Please remove and replace
with a check in UserManager::DownloadProfileImage.

[sail, 2011/11/15 20:17:22]

Done.

+
+  // Returns the browser profile associated with this download request.
+  virtual Profile* GetBrowserProfile() = 0;
+
+  // Called when image is successfully downloaded and decoded.
+  virtual void OnDownloadSuccess(const string16& full_name,

[Ivan Korotkov, 2011/11/15 12:29:04]

As discussed offline with Anton, it's a bad idea to pass full_name here because:
if image download fails (but API returns a valid username) the delegate won't
receive full name it all.

What about adding another method to delegate like OnFullNameAvailable(const
string16& full_name) and remove full_name from other callbacks?

[sail, 2011/11/15 20:17:22]

To simplify things I replaced the three OnDownload*() callbacks to a single
OnDownloadComplete(bool success) callback. The delegate can now ask the
ProfileDownloader for the various downloaded results.

+                                 const SkBitmap& image) = 0;
+
+  // Called on download failure.
+  virtual void OnDownloadFailure() {}
+
+  // Called when user has the default profile image and we won't download
+  // it.
+  virtual void OnDownloadDefaultImage(const string16& full_name) {}
+};
+
+#endif  // CHROME_BROWSER_GAIA_USERINFO_PROFILE_DOWNLOADER_DELEGATE_H_