Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 8510069: Make ProfileImageDownloader available to non-chromeos code (Closed)

Created:
9 years, 1 month ago by sail
Modified:
9 years, 1 month ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Make ProfileImageDownloader available to non-chromeos code BUG=91241 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111098

Patch Set 1 #

Patch Set 2 : fix build #

Total comments: 26

Patch Set 3 : address review comments #

Patch Set 4 : move fiels #

Patch Set 5 : fix build #

Patch Set 6 : move file to pofiles/ #

Patch Set 7 : fix build #

Total comments: 14

Patch Set 8 : address review comments #

Patch Set 9 : renaem GetDesiredImageSize to GetDesiredImageSideLength #

Patch Set 10 : fix build #

Patch Set 11 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -662 lines) Patch
M chrome/browser/chromeos/login/captcha_view.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/login/image_decoder.h View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/chromeos/login/image_decoder.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -68 lines 0 comments Download
M chrome/browser/chromeos/login/image_downloader.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
D chrome/browser/chromeos/login/profile_image_downloader.h View 1 chunk +0 lines, -97 lines 0 comments Download
D chrome/browser/chromeos/login/profile_image_downloader.cc View 1 chunk +0 lines, -297 lines 0 comments Download
M chrome/browser/chromeos/login/user_image_loader.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_image_loader.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager.h View 1 2 3 4 5 6 7 8 9 10 4 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager.cc View 1 2 3 4 5 6 7 8 4 chunks +69 lines, -50 lines 0 comments Download
A + chrome/browser/image_decoder.h View 1 2 3 3 chunks +3 lines, -7 lines 0 comments Download
A + chrome/browser/image_decoder.cc View 1 2 3 4 5 6 7 3 chunks +1 line, -5 lines 0 comments Download
A chrome/browser/profiles/profile_downloader.h View 1 2 3 4 5 6 7 1 chunk +83 lines, -0 lines 0 comments Download
A + chrome/browser/profiles/profile_downloader.cc View 1 2 3 4 5 6 7 8 14 chunks +65 lines, -57 lines 0 comments Download
A chrome/browser/profiles/profile_downloader_delegate.h View 1 2 3 4 5 6 7 8 1 chunk +36 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
sail
9 years, 1 month ago (2011-11-14 22:11:10 UTC) #1
Ivan Korotkov
LGTM http://codereview.chromium.org/8510069/diff/1013/chrome/browser/gaia_userinfo/profile_downloader.cc File chrome/browser/gaia_userinfo/profile_downloader.cc (right): http://codereview.chromium.org/8510069/diff/1013/chrome/browser/gaia_userinfo/profile_downloader.cc#newcode173 chrome/browser/gaia_userinfo/profile_downloader.cc:173: ProfileDownloader::ProfileDownloader(Delegate* delegate) : delegate_(delegate) { Please break line ...
9 years, 1 month ago (2011-11-15 11:05:08 UTC) #2
whywhat
lgtm Please, make sure you run linux_clang and linux_chromeos bots before committing. http://codereview.chromium.org/8510069/diff/1013/chrome/browser/chromeos/login/captcha_view.h File chrome/browser/chromeos/login/captcha_view.h ...
9 years, 1 month ago (2011-11-15 12:19:21 UTC) #3
Ivan Korotkov
http://codereview.chromium.org/8510069/diff/1013/chrome/browser/gaia_userinfo/profile_downloader_delegate.h File chrome/browser/gaia_userinfo/profile_downloader_delegate.h (right): http://codereview.chromium.org/8510069/diff/1013/chrome/browser/gaia_userinfo/profile_downloader_delegate.h#newcode30 chrome/browser/gaia_userinfo/profile_downloader_delegate.h:30: virtual void OnDownloadSuccess(const string16& full_name, As discussed offline with ...
9 years, 1 month ago (2011-11-15 12:29:04 UTC) #4
sail
Moved files to chrome/browser and chrome/browser/net. Changed delegate callback to make things simpler. Please take ...
9 years, 1 month ago (2011-11-15 20:17:21 UTC) #5
sail
chrome/browser/net OWNERS: +battre, +jar
9 years, 1 month ago (2011-11-15 20:18:20 UTC) #6
sail
9 years, 1 month ago (2011-11-15 20:18:40 UTC) #7
battre
I think chrome/browser/net is the wrong place to put the ProfileDownloader as it is not ...
9 years, 1 month ago (2011-11-16 13:05:15 UTC) #8
sail
moved files from browser/net to browser/profiles
9 years, 1 month ago (2011-11-16 15:51:30 UTC) #9
battre
On 2011/11/16 15:51:30, sail wrote: > moved files from browser/net to browser/profiles Thanks. I assume ...
9 years, 1 month ago (2011-11-16 15:55:52 UTC) #10
Ivan Korotkov
Another LGTM but please make sure that try passes for linux_chromeos *and* linux_chromeos_clang (it compiles ...
9 years, 1 month ago (2011-11-17 08:37:11 UTC) #11
sail
http://codereview.chromium.org/8510069/diff/1013/chrome/browser/gaia_userinfo/profile_downloader_delegate.h File chrome/browser/gaia_userinfo/profile_downloader_delegate.h (right): http://codereview.chromium.org/8510069/diff/1013/chrome/browser/gaia_userinfo/profile_downloader_delegate.h#newcode20 chrome/browser/gaia_userinfo/profile_downloader_delegate.h:20: // Returns the desierd size of the profile image. ...
9 years, 1 month ago (2011-11-21 22:01:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/8510069/29001
9 years, 1 month ago (2011-11-22 02:12:06 UTC) #13
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 03:56:11 UTC) #14
Change committed as 111098

Powered by Google App Engine
This is Rietveld 408576698