Issue 8510068: Using path in SHARED_INTERMEDIATE_DIR rather than PRODUCT_DIR to be consistent with

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8510068: Using path in SHARED_INTERMEDIATE_DIR rather than PRODUCT_DIR to be consistent with (Closed)

Created:
9 years, 1 month ago by bradn

Modified:
9 years, 1 month ago

Reviewers:
dmichael (off chromium), noelallen_use_chromium, wez1, Wez

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Using path in SHARED_INTERMEDIATE_DIR rather than PRODUCT_DIR to be consistent with untrusted.gypi. Ninja has a different layout, which this was breaking. BUG=None TEST=None R=noelallen@google.com,wez@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110015

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
	M	ppapi/native_client/native_client.gyp	View		1 chunk	+12 lines, -12 lines	0 comments	Download

Total messages: 3 (0 generated)

LGTM