Fix String.trim implementation (follow spec).

runtime/lib/string.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * [StringBase] contains common methods used by concrete String implementations,
  * e.g., OneByteString.
  */
 class StringBase {
 
@@ skipping 142 matching lines @@
   String substringUnchecked_(int startIndex, int endIndex) {
     int len = endIndex - startIndex;
     List<int> charCodes = new List<int>(len);
     for (int i = 0; i < len; i++) {
       charCodes[i] = this.charCodeAt(startIndex + i);
     }
     return StringBase.createFromCharCodes(charCodes);
   }
 
   String trim() {
-    int len = this.length;
+    final int len = this.length;
     int first = 0;
     for (; first < len; first++) {
       if (!_isWhitespace(this.charCodeAt(first))) {
         break;
       }
     }
     if (len == first) {
       // String contains only whitespaces.
       return "";
     }
     int last = len - 1;
-    for (int i = last; last >= first; last--) {
+    for (; last >= first; last--) {
       if (!_isWhitespace(this.charCodeAt(last))) {
         break;
       }
     }
-    return substringUnchecked_(first, last + 1);
+    if ((first == 0) && (last == (len - 1))) {
+      // Returns this string if it does not have leading or trailing
+      // whitespaces.
+      return this;
+    } else {
+      return substringUnchecked_(first, last + 1);
+    }
   }
 
   bool contains(Pattern other, [int startIndex = 0]) {
     if (other is String) {
       return indexOf(other, startIndex) >= 0;
     }
     return other.allMatches(this.substring(startIndex)).iterator().hasNext();
   }
 
   String replaceFirst(Pattern from, String to) {
@@ skipping 245 matching lines @@
     for (int g in groups) {
       result.add(group(g));
     }
     return result;
   }
 
   final int _start;
   final String str;
   final String pattern;
 }