Issue 8510065: Only inject one copy of the javascript based 'LayoutTestController' instance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8510065: Only inject one copy of the javascript based 'LayoutTestController' instance. (Closed)

Created:
9 years, 1 month ago by michaeln

Modified:
9 years, 1 month ago

Reviewers:
jianli

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Only inject one copy of the javascript based 'LayoutTestController' instance. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110999

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/test/ui/ui_layout_test.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jianli

9 years, 1 month ago (2011-11-14 19:29:13 UTC) #2

LGTM.

On Mon, Nov 14, 2011 at 11:21 AM, <michaeln@chromium.org> wrote:

> Reviewers: jianli,
>
> Message:
> ptal
>
> Description:
> Only inject one copy of the javascript based 'LayoutTestController'
> instance.
>
> Please review this at
http://codereview.chromium.**org/8510065/<http://codereview.chromium.org/8510...
>
> SVN Base: svn://chrome-svn/chrome/trunk/**src/
>
> Affected files:
>  M     chrome/test/ui/ui_layout_test.**cc
>
>
> Index: chrome/test/ui/ui_layout_test.**cc
> ==============================**==============================**=======
> --- chrome/test/ui/ui_layout_test.**cc    (revision 109908)
> +++ chrome/test/ui/ui_layout_test.**cc    (working copy)
> @@ -149,6 +149,7 @@
>   PathService::Get(chrome::DIR_**TEST_DATA, &path);
>   path = path.AppendASCII("layout_**tests");
>   path = path.AppendASCII("layout_test_**controller.html");
> +  layout_test_controller_.clear(**);
>   ASSERT_TRUE(file_util::**ReadFileToString(path,
> &layout_test_controller_));
>  }
>
>
>
>

Expand Messages | Collapse Messages