Removing extension name suffix from the metric name in chrome.experimental.metrics

chrome/browser/extensions/extension_metrics_module.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_metrics_module.h"
 
 #include "base/metrics/histogram.h"
 #include "base/values.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/browser/ui/options/options_util.h"
 #include "chrome/installer/util/google_update_settings.h"
 #include "content/browser/user_metrics.h"
 
 using base::Histogram;
 using base::LinearHistogram;
 
 namespace {
 
-// Build the full name of a metrics for the given extension.  Each metric
-// is made up of the unique name within the extension followed by the
-// extension's id.  This keeps the metrics from one extension unique from
-// other extensions, as well as those metrics from chrome itself.
+// Build the full name of a metrics for the given extension.
+// For a non-component extension the metric name is made up of the unique name
+// within the extension followed by the extension's id. This keeps the metrics
+// from one extension unique from other extensions, as well as those metrics
+// from chrome itself.
+// For a component extension the metric name is used as is. There are not so
+// many of them and it is easy enough to prevent name clashes.
 std::string BuildMetricName(const std::string& name,
                             const Extension* extension) {
   std::string full_name(name);
-  full_name += extension->id();
+  if (extension->location() != Extension::COMPONENT)
+    full_name += extension->id();
   return full_name;
 }
 
 }  // anonymous namespace
 
-// These extension function classes are enabled only if the
-// enable-metrics-extension-api command line switch is used.  Refer to
-// extension_function_dispatcher.cc to see how they are enabled.
-
 bool MetricsSetEnabledFunction::RunImpl() {
   bool enabled = false;
   EXTENSION_FUNCTION_VALIDATE(args_->GetBoolean(0, &enabled));
 
   // Using OptionsUtil is better because it actually ensures we reset all the
   // necessary threads. This is the main way for starting / stopping UMA and
   // crash reporting.
   // This method will return the resulting enabled, which we send to JS.
   bool result = OptionsUtil::ResolveMetricsReportingEnabled(enabled);
   result_.reset(Value::CreateBooleanValue(result));
@@ skipping 116 matching lines @@
   return RecordValue(name, Histogram::HISTOGRAM, 1, kThreeMinMs, 50, sample);
 }
 
 bool MetricsRecordLongTimeFunction::RunImpl() {
   std::string name;
   int sample;
   EXTENSION_FUNCTION_VALIDATE(GetNameAndSample(&name, &sample));
   static const int kOneHourMs = 60 * 60 * 1000;
   return RecordValue(name, Histogram::HISTOGRAM, 1, kOneHourMs, 50, sample);
 }