Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 8510043: Re-enable RenderWidgetHostTest.PreHandleRawKeyDownEvent (Closed)

Created:
9 years, 1 month ago by Jun Mukai
Modified:
9 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., jam, dpranke-watch+content_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Re-enable RenderWidgetHostTest.PreHandleRawKeyDownEvent This test is working as expected, at least on my local machine. BUG=chromium:100345 TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110751

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Jun Mukai
9 years, 1 month ago (2011-11-18 08:29:58 UTC) #1
Emmanuel Saint-loubert-Bié
When you say on your machine, so you mean Stumpy or Linux?
9 years, 1 month ago (2011-11-18 15:01:37 UTC) #2
Emmanuel Saint-loubert-Bié
I will do a test on my stumpy this morning, before we review/push this.
9 years, 1 month ago (2011-11-18 15:04:06 UTC) #3
Jun Mukai
On 2011/11/18 15:01:37, Emmanuel Saint-loubert wrote: > When you say on your machine, so you ...
9 years, 1 month ago (2011-11-18 15:16:14 UTC) #4
James Cook
LGTM assuming it works on CrOS hardware.
9 years, 1 month ago (2011-11-18 17:40:30 UTC) #5
sky
LGTM Feel free to TBR changes like this in the future.
9 years, 1 month ago (2011-11-18 18:58:52 UTC) #6
Emmanuel Saint-loubert-Bié
lgtm
9 years, 1 month ago (2011-11-18 19:16:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/8510043/1
9 years, 1 month ago (2011-11-18 19:18:35 UTC) #8
commit-bot: I haz the power
9 years, 1 month ago (2011-11-18 20:55:28 UTC) #9
Change committed as 110751

Powered by Google App Engine
This is Rietveld 408576698