Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: chrome/browser/resources/options/search_engine_manager_engine_list.js

Issue 8510042: fix appearance of buttons in chrome://settings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: also one breakage found in ntp Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/resources/options/options.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options.search_engines', function() { 5 cr.define('options.search_engines', function() {
6 const InlineEditableItemList = options.InlineEditableItemList; 6 const InlineEditableItemList = options.InlineEditableItemList;
7 const InlineEditableItem = options.InlineEditableItem; 7 const InlineEditableItem = options.InlineEditableItem;
8 const ListSelectionController = cr.ui.ListSelectionController; 8 const ListSelectionController = cr.ui.ListSelectionController;
9 9
10 /** 10 /**
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 var urlEl = this.createEditableTextCell(engine['url']); 115 var urlEl = this.createEditableTextCell(engine['url']);
116 var urlWithButtonEl = this.ownerDocument.createElement('div'); 116 var urlWithButtonEl = this.ownerDocument.createElement('div');
117 urlWithButtonEl.appendChild(urlEl); 117 urlWithButtonEl.appendChild(urlEl);
118 urlWithButtonEl.className = 'url-column'; 118 urlWithButtonEl.className = 'url-column';
119 urlWithButtonEl.classList.add('weakrtl'); 119 urlWithButtonEl.classList.add('weakrtl');
120 this.contentElement.appendChild(urlWithButtonEl); 120 this.contentElement.appendChild(urlWithButtonEl);
121 // Add the Make Default button. Temporary until drag-and-drop re-ordering 121 // Add the Make Default button. Temporary until drag-and-drop re-ordering
122 // is implemented. When this is removed, remove the extra div above. 122 // is implemented. When this is removed, remove the extra div above.
123 if (engine['canBeDefault']) { 123 if (engine['canBeDefault']) {
124 var makeDefaultButtonEl = this.ownerDocument.createElement('button'); 124 var makeDefaultButtonEl = this.ownerDocument.createElement('button');
125 makeDefaultButtonEl.className = "raw-button"; 125 makeDefaultButtonEl.className = 'raw-button custom-appearance';
126 makeDefaultButtonEl.textContent = 126 makeDefaultButtonEl.textContent =
127 templateData.makeDefaultSearchEngineButton; 127 templateData.makeDefaultSearchEngineButton;
128 makeDefaultButtonEl.onclick = function(e) { 128 makeDefaultButtonEl.onclick = function(e) {
129 chrome.send('managerSetDefaultSearchEngine', [engine['modelIndex']]); 129 chrome.send('managerSetDefaultSearchEngine', [engine['modelIndex']]);
130 }; 130 };
131 // Don't select the row when clicking the button. 131 // Don't select the row when clicking the button.
132 makeDefaultButtonEl.onmousedown = function(e) { 132 makeDefaultButtonEl.onmousedown = function(e) {
133 e.stopPropagation(); 133 e.stopPropagation();
134 }; 134 };
135 urlWithButtonEl.appendChild(makeDefaultButtonEl); 135 urlWithButtonEl.appendChild(makeDefaultButtonEl);
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
307 }, 307 },
308 }; 308 };
309 309
310 // Export 310 // Export
311 return { 311 return {
312 SearchEngineList: SearchEngineList 312 SearchEngineList: SearchEngineList
313 }; 313 };
314 314
315 }); 315 });
316 316
OLDNEW
« no previous file with comments | « chrome/browser/resources/options/options.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698