Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 8510042: fix appearance of buttons in chrome://settings (Closed)

Created:
9 years, 1 month ago by Evan Stade
Modified:
9 years, 1 month ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

fix appearance of buttons in chrome://settings non-standard buttons in chrome://settings were broken in r109201 because the specificity of the button rules got greater when :not(.custom-appearance) was added. This is a sorry and unanticipated side effect of this approach (proposed by yours truly). BUG=none TEST=deletable list item close buttons, subpage close buttons go back to normal look Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109759

Patch Set 1 #

Patch Set 2 : also one breakage found in ntp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M chrome/browser/resources/ntp4/new_tab.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/accounts_user_list.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/deletable_item_list.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/options.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/search_engine_manager_engine_list.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Stade
it might behoove us to add css for custom-button into button.css, but for now I ...
9 years, 1 month ago (2011-11-10 04:29:53 UTC) #1
sail
LGTM. Arg... really sorry about this.
9 years, 1 month ago (2011-11-10 04:37:37 UTC) #2
Evan Stade
On 2011/11/10 04:29:53, Evan Stade wrote: > it might behoove us to add css for ...
9 years, 1 month ago (2011-11-10 17:52:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/8510042/6
9 years, 1 month ago (2011-11-11 22:43:01 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-11 22:43:03 UTC) #5
Can't apply patch for file
chrome/browser/resources/options/chromeos/accounts_user_list.js.
While running patch -p1 --forward --force;
patching file chrome/browser/resources/options/chromeos/accounts_user_list.js
Hunk #1 FAILED at 191.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/resources/options/chromeos/accounts_user_list.js.rej

Powered by Google App Engine
This is Rietveld 408576698