Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 8510032: Add tests to make sure gpu blacklist actually block gpu features. (Closed)

Created:
9 years, 1 month ago by Zhenyao Mo
Modified:
9 years, 1 month ago
CC:
chromium-reviews, jam, apatrick_chromium, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add tests to make sure gpu blacklist actually block gpu features. (Retry after a fix.) The general idea is to use jbates's newly added tracing: if a feature is blacklisted, we check the tracing data to make sure gpu process hasn't launched. BUG=101222 TEST=browser_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109740

Patch Set 1 : '' #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -0 lines) Patch
M chrome/chrome_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/gpu/feature_canvas2d.html View 1 chunk +35 lines, -0 lines 0 comments Download
A chrome/test/data/gpu/feature_compositing.html View 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/test/data/gpu/feature_webgl.html View 1 chunk +33 lines, -0 lines 0 comments Download
A chrome/test/gpu/gpu_feature_browsertest.cc View 1 1 chunk +177 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Zhenyao Mo
Sorry for this, but the Cl you reviewed yesterday was reverted due to a Win ...
9 years, 1 month ago (2011-11-10 00:54:42 UTC) #1
jbates
lgtm
9 years, 1 month ago (2011-11-10 01:06:18 UTC) #2
Zhenyao Mo
Al: ping.
9 years, 1 month ago (2011-11-11 00:23:43 UTC) #3
apatrick_chromium
LGTM
9 years, 1 month ago (2011-11-11 19:52:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/8510032/10001
9 years, 1 month ago (2011-11-11 20:04:52 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-11 21:09:17 UTC) #6
Try job failure for 8510032-10001 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698