base: export GetBuildTime

base/build_time_unittest.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/build_time.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+TEST(BuildTime, DateLooksValid) {
+  char build_date[] = __DATE__;
+
+  EXPECT_EQ(11u, strlen(build_date));
+  EXPECT_EQ(' ', build_date[3]);
+  EXPECT_EQ(' ', build_date[6]);
+}
+
+TEST(BuildTime, TimeLooksValid) {
+  char build_time[] = __TIME__;
+
+  EXPECT_EQ(8u, strlen(build_time));
+  EXPECT_EQ(':', build_time[2]);
+  EXPECT_EQ(':', build_time[5]);
+}
+
+TEST(BuildTime, DoesntCrash) {
+  // Since __DATE__ isn't updated unless one does a clobber build, we can't
+  // really test the value returned by it, except to check that it doesn't
+  // crash.
+  base::GetBuildTime();

[jar (doing other things), 2011/11/09 22:51:31]

You could compare to Now(), and it should always be older than  that time.

[agl, 2011/11/10 19:02:58]

I don't think that we can do that. I've set the timezone for GetBuildTime to PST
(because it probably is) but, if you are west of PST, Now will be less than
GetBuildTime.

[jar (doing other things), 2011/11/11 02:48:35]

Maybe it is too much of a hassle.... but you can get Now() into PST, and then
you'd be able to compare.

Thinking about it some more... perhaps if you use the default time zone (for
both), or GMT (as the follow on string for __TIME__), the times would be
comparable.  One or the other should surely(?) do the trick.

My head hurts a little thinking about this... and I'd have to write test code to
see the pattern.

It is not at that critical, so I'm going LGTM ;-).



On 2011/11/10 19:02:58, agl wrote:

+}