base: export GetBuildTime

base: export GetBuildTime

A need for the function came up in another context so this change exposes it
from base/.

BUG=none
TEST=base_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109638

[jar (doing other things), 2011-11-09 22:51:31]

Two small suggestions below.  If you argue they are bad suggestions, I'll
approve the change as is.

http://codereview.chromium.org/8510027/diff/1/base/build_time.h
File base/build_time.h (right):

http://codereview.chromium.org/8510027/diff/1/base/build_time.h#newcode20
base/build_time.h:20: // Also, since __TIME__ doesn't include a timezone, this
value should only be
suggestion: Append a timezone, so that the result of this call will be
independent of teh region you run in.  Without a trailing timezone, the value
will be locale dependent... which is an unnecessary variable.  You can append
the timezone at compile time by just putting a quoted string next to __TIME__.

http://codereview.chromium.org/8510027/diff/1/base/build_time_unittest.cc
File base/build_time_unittest.cc (right):

http://codereview.chromium.org/8510027/diff/1/base/build_time_unittest.cc#new...
base/build_time_unittest.cc:29: base::GetBuildTime();
You could compare to Now(), and it should always be older than  that time.

[agl, 2011-11-10 19:02:58]

http://codereview.chromium.org/8510027/diff/1/base/build_time.h
File base/build_time.h (right):

http://codereview.chromium.org/8510027/diff/1/base/build_time.h#newcode20
base/build_time.h:20: // Also, since __TIME__ doesn't include a timezone, this
value should only be
On 2011/11/09 22:51:31, jar wrote:
> suggestion: Append a timezone, so that the result of this call will be
> independent of teh region you run in.  Without a trailing timezone, the value
> will be locale dependent... which is an unnecessary variable.  You can append
> the timezone at compile time by just putting a quoted string next to __TIME__.

Done.

http://codereview.chromium.org/8510027/diff/1/base/build_time_unittest.cc
File base/build_time_unittest.cc (right):

http://codereview.chromium.org/8510027/diff/1/base/build_time_unittest.cc#new...
base/build_time_unittest.cc:29: base::GetBuildTime();
On 2011/11/09 22:51:31, jar wrote:
> You could compare to Now(), and it should always be older than  that time.

I don't think that we can do that. I've set the timezone for GetBuildTime to PST
(because it probably is) but, if you are west of PST, Now will be less than
GetBuildTime.

[jar (doing other things), 2011-11-11 02:48:35]

lgtm

http://codereview.chromium.org/8510027/diff/1/base/build_time_unittest.cc
File base/build_time_unittest.cc (right):

http://codereview.chromium.org/8510027/diff/1/base/build_time_unittest.cc#new...
base/build_time_unittest.cc:29: base::GetBuildTime();
Maybe it is too much of a hassle.... but you can get Now() into PST, and then
you'd be able to compare.

Thinking about it some more... perhaps if you use the default time zone (for
both), or GMT (as the follow on string for __TIME__), the times would be
comparable.  One or the other should surely(?) do the trick.

My head hurts a little thinking about this... and I'd have to write test code to
see the pattern.

It is not at that critical, so I'm going LGTM ;-).



On 2011/11/10 19:02:58, agl wrote:
> On 2011/11/09 22:51:31, jar wrote:
> > You could compare to Now(), and it should always be older than  that time.
> 
> I don't think that we can do that. I've set the timezone for GetBuildTime to
PST
> (because it probably is) but, if you are west of PST, Now will be less than
> GetBuildTime.

[commit-bot: I haz the power, 2011-11-11 15:09:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agl@chromium.org/8510027/5001

[commit-bot: I haz the power, 2011-11-11 16:09:38]

Change committed as 109638