Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 8510024: Force navigation to non-numeric hostnames with ports (e.g. "abc:81"). This restores the pre-Chro... (Closed)

Created:
9 years, 1 month ago by Peter Kasting
Modified:
9 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, James Su, Paweł Hajdan Jr.
Visibility:
Public.

Description

Force navigation to non-numeric hostnames with ports (e.g. "abc:81"). This restores the pre-Chrome-15 behavior for these inputs. BUG=103598 TEST=Typing "abcdefg:123" in the address bar should attempt to navigate, not search, by default. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110821

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M chrome/browser/autocomplete/autocomplete.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_unittest.cc View 3 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
9 years, 1 month ago (2011-11-09 21:21:33 UTC) #1
sky
9 years, 1 month ago (2011-11-09 22:23:21 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698