Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 851002: Fix assigned variables analysis.... (Closed)

Created:
10 years, 9 months ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix assigned variables analysis. This change fixes a bug with the arguments object that occurred with r4087 and r4088. The fix is not marking the arguments variable as trivial since it can have side effects. Committed: http://code.google.com/p/v8/source/detail?r=4099

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+704 lines, -87 lines) Patch
M src/arm/virtual-frame-arm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ast.h View 11 chunks +32 lines, -3 lines 0 comments Download
M src/ast.cc View 1 chunk +15 lines, -1 line 0 comments Download
M src/compiler.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M src/data-flow.h View 1 chunk +35 lines, -0 lines 0 comments Download
M src/data-flow.cc View 2 chunks +441 lines, -0 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 6 chunks +131 lines, -78 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/ia32/virtual-frame-ia32.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/virtual-frame-ia32.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M src/scopes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/virtual-frame-inl.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/x64/virtual-frame-x64.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
10 years, 9 months ago (2010-03-11 10:11:26 UTC) #1
Kevin Millikin (Chromium)
10 years, 9 months ago (2010-03-11 10:23:34 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698