Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 8510014: Add MIPS support to top-level Makefile (Closed)

Created:
9 years, 1 month ago by Jakob Kummerow
Modified:
9 years, 1 month ago
Reviewers:
Sven Panne, Yang
CC:
v8-dev
Visibility:
Public.

Description

Add MIPS support to top-level Makefile For now, MIPS targets are not included in the "all", "release", "debug" and corresponding ".check" convenience targets, but they can be built explicitly (e.g. "mips.release.check"). Committed: http://code.google.com/p/v8/source/detail?r=9943

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M Makefile View 5 chunks +11 lines, -4 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Jakob Kummerow
PTAL.
9 years, 1 month ago (2011-11-09 16:05:31 UTC) #1
Yang
LGTM if sufficiently tested.
9 years, 1 month ago (2011-11-09 16:07:45 UTC) #2
Sven Panne
http://codereview.chromium.org/8510014/diff/1/Makefile File Makefile (right): http://codereview.chromium.org/8510014/diff/1/Makefile#newcode150 Makefile:150: --arch=$(shell echo $(DEFAULT_ARCHES) | sed -e 's/ /,/g') \ ...
9 years, 1 month ago (2011-11-09 16:10:20 UTC) #3
Jakob Kummerow
9 years, 1 month ago (2011-11-09 16:20:03 UTC) #4
On 2011/11/09 16:10:20, Sven wrote:
> http://codereview.chromium.org/8510014/diff/1/Makefile
> File Makefile (right):
> 
> http://codereview.chromium.org/8510014/diff/1/Makefile#newcode150
> Makefile:150: --arch=$(shell echo $(DEFAULT_ARCHES) | sed -e 's/ /,/g') \
> No need for sed, use subst:
> http://www.gnu.org/s/hello/manual/make/Syntax-of-Functions.html

The space/comma hack required for that is pretty ugly, making me prefer the
shell command.

Powered by Google App Engine
This is Rietveld 408576698