Issue 8509037: Revert 109826 - Re-authenticate oauth tokens after crash and restart Sync.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8509037: Revert 109826 - Re-authenticate oauth tokens after crash and restart Sync. (Closed)

Created:
9 years, 1 month ago by Timur Iskhodzhanov

Modified:
9 years, 1 month ago

Reviewers:
Nikita (slow), zel

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 109826 - Re-authenticate oauth tokens after crash and restart Sync. BUG=chromium-os:19788 TEST=See issue Review URL: http://codereview.chromium.org/8537002 TBR=zelidrag@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109837

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -32 lines)			Patch
M	chrome/browser/chrome_browser_main.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_utils.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_utils.cc	View	4 chunks	+8 lines, -23 lines	0 comments	Download
M	chrome/browser/chromeos/login/mock_authenticator.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

It would be nice to have a mention in Revert message why CL was reverted.

9 years, 1 month ago (2011-11-14 13:05:43 UTC) #2

Timur Iskhodzhanov

I agree, will do better next time. Zel asked me to. The ui_tests were red ...

9 years, 1 month ago (2011-11-14 13:26:16 UTC) #3

zel

9 years, 1 month ago (2011-11-14 18:55:46 UTC) #4

Yep, my CL caused test regressions. I will have a better fix soon once I
resolve ui_tests issues here. Thanks for taking care of this one Timur!

On Mon, Nov 14, 2011 at 5:26 AM, <timurrrr@chromium.org> wrote:

> I agree, will do better next time.
>
> Zel asked me to.
> The ui_tests were red all over the place (CrOS waterfall, Memory FYI
> waterfall)
>
>
http://codereview.chromium.**org/8509037/<http://codereview.chromium.org/8509...
>

Expand Messages | Collapse Messages