Issue 8509033: WebUI TaskManager: small UI fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8509033: WebUI TaskManager: small UI fixes (Closed)

Created:
9 years, 1 month ago by yoshiki

Modified:
9 years, 1 month ago

Reviewers:
mazda

CC:
chromium-reviews, arv (Not doing code reviews), yoshiki+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

WebUI TaskManager: small UI fixes - Use global chrome style by including CSS. - Prevent page entire scrolling on Mac. - Adjust margin. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109383

Patch Set 1 #

Total comments: 4

Patch Set 2 : to be commited. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	chrome/browser/resources/task_manager/includes.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/resources/task_manager/task_manager.css	View	1	4 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mazda

lgtm http://codereview.chromium.org/8509033/diff/1/chrome/browser/resources/task_manager/task_manager.css File chrome/browser/resources/task_manager/task_manager.css (right): http://codereview.chromium.org/8509033/diff/1/chrome/browser/resources/task_manager/task_manager.css#newcode47 chrome/browser/resources/task_manager/task_manager.css:47: margin: 4px 4px 2px 4px; This can be ...

9 years, 1 month ago (2011-11-10 05:37:36 UTC) #2

yoshiki

9 years, 1 month ago (2011-11-10 06:20:55 UTC) #3

committed. thanks!

http://codereview.chromium.org/8509033/diff/1/chrome/browser/resources/task_m...
File chrome/browser/resources/task_manager/task_manager.css (right):

http://codereview.chromium.org/8509033/diff/1/chrome/browser/resources/task_m...
chrome/browser/resources/task_manager/task_manager.css:47: margin: 4px 4px 2px
4px;
On 2011/11/10 05:37:37, mazda wrote:
> This can be written as follows.
> margin: 4px 4px 2px;

Done.

http://codereview.chromium.org/8509033/diff/1/chrome/browser/resources/task_m...
chrome/browser/resources/task_manager/task_manager.css:146: margin: 2px 4px 4px
4px;
On 2011/11/10 05:37:37, mazda wrote:
> margin: 2px 4px 4px;

Done.

Expand Messages | Collapse Messages