Issue 8509005: Remove ast-inl.h. This file is not necessary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8509005: Remove ast-inl.h. This file is not necessary. (Closed)

Created:
9 years, 1 month ago by Kevin Millikin (Chromium)

Modified:
9 years, 1 month ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Remove ast-inl.h. This file is not necessary. R=svenpanne@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9924

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -143 lines)			Patch
M	src/ast.h	View	8 chunks	+59 lines, -11 lines	0 comments	Download
M	src/ast.cc	View	1 chunk	+15 lines, -0 lines	0 comments	Download
D	src/ast-inl.h	View	1 chunk	+0 lines, -131 lines	0 comments	Download
M	src/parser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Kevin Millikin (Chromium)

Story: I was cleaning up and noticed that not all the functions defined in ast-inl.h ...

9 years, 1 month ago (2011-11-09 10:44:17 UTC) #1

Sven Panne

9 years, 1 month ago (2011-11-09 11:03:45 UTC) #2

Anger, fear, aggression, code in headers. The dark side are they. Once you start
down the dark path, forever will it dominate your destiny. :-) LGTM.