src/profile-generator.h - Issue 8509003: Limit length of strings copied into a heap snapshot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/profile-generator.h

Issue 8509003: Limit length of strings copied into a heap snapshot (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/profile-generator.h

diff --git a/src/profile-generator.h b/src/profile-generator.h

index 0eb73bef97251fad36ddbb368ec0d952e7d31bd9..1c4520e1eeddfe5f977ff582b1d9e6330813fcf0 100644

--- a/src/profile-generator.h

+++ b/src/profile-generator.h

@@ -74,6 +74,8 @@ class StringsStorage {

inline const char* GetFunctionName(const char* name);

private:

+ static const uint32_t kMaxNameSize;

mnaganov (inactive) 2011/11/09 11:45:23 Static consts are preferred to be initialized in t

INLINE(static bool StringsMatch(void* key1, void* key2)) {

return strcmp(reinterpret_cast<char*>(key1),

reinterpret_cast<char*>(key2)) == 0;