Add functionality to the GCAPI to detect when Chrome was last run.

chrome/chrome_installer.gypi

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'lastchange_path': '<(SHARED_INTERMEDIATE_DIR)/build/LASTCHANGE',
     # 'branding_dir' is set in the 'conditions' section at the bottom.
   },
   'conditions': [
     ['OS=="win"', {

[grt (UTC plus 2), 2011/11/11 17:01:01]

now that this relies on base, gcapi_dll can only be shipped when
component=="static_library".  i can see that it may be useful to be able to work
on gcapi in a component build, but we shouldn't ever make a shipping binary that
way.  how about adding something like 'component=="static_library"' to the
conditions?

[robertshield, 2011/11/12 05:25:38]

Meaning that gcapi_dll wouldn't be present in the component build? We don't do
that for any of the other shipping components do we?

Ideally I'd like a way to enforce that gcapi_dll.dll always statically linked
base et al, but I don't know of a way of doing that beyond tracking all the
things component=='shared_library' modifies and adding back their defaults here,
which isn't maintainable.

[grt (UTC plus 2), 2011/11/14 14:24:09]

Nod.  I agree that it would be strange to special-case this (since other
shipping things aren't disabled in component builds).  I was a bit concerned
about this being "shipped" from someone's dev checkout, but hopefully this won't
happen.

       'targets': [
         {
           'target_name': 'gcapi_dll',
           'type': 'loadable_module',
           'dependencies': [
+            'installer_util',
+            '<(DEPTH)/base/base.gyp:base',
             '<(DEPTH)/google_update/google_update.gyp:google_update',
           ],
           'include_dirs': [
             '<(DEPTH)',
           ],
           'sources': [
             'installer/gcapi/gcapi.cc',
             'installer/gcapi/gcapi.h',
           ],
         },
         {
           'target_name': 'gcapi_lib',
           'type': 'static_library',
           'dependencies': [
+            'installer_util',

[grt (UTC plus 2), 2011/11/11 17:01:01]

why doesn't this also depend on base like gcapi_dll does?

[robertshield, 2011/11/12 05:25:38]

It does, I just forgot to add it. It likely builds because it picks it up from
installer_util (at a guess). Added the dependency explicitly.

             '<(DEPTH)/google_update/google_update.gyp:google_update',
           ],
           'include_dirs': [
             '<(DEPTH)',
           ],
           'sources': [
             'installer/gcapi/gcapi.cc',
             'installer/gcapi/gcapi.h',
           ],
         },
         {
           'target_name': 'gcapi_test',
           'type': 'executable',
-          'dependencies': [
+          'dependencies': [   
+            'common',
             'gcapi_dll',
             'gcapi_lib',
+            'installer_util',
+            '<(DEPTH)/base/base.gyp:base',
+            '<(DEPTH)/base/base.gyp:test_support_base',
+            '<(DEPTH)/testing/gtest.gyp:gtest',
           ],
           'include_dirs': [
             '<(DEPTH)',
           ],
           'sources': [
+            'installer/gcapi/gcapi_last_run_test.cc',
             'installer/gcapi/gcapi_test.cc',
             'installer/gcapi/gcapi_test.rc',
             'installer/gcapi/resource.h',
           ],
         },
         {
           'target_name': 'installer_util_unittests',
           'type': 'executable',
           'dependencies': [
             'installer_util',
@@ skipping 861 matching lines @@
       'variables': {
          'branding_dir': 'app/theme/google_chrome',
       },
     }, { # else branding!="Chrome"
       'variables': {
          'branding_dir': 'app/theme/chromium',
       },
     }],
   ],
 }