Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: webkit/blob/webkit_blob.gypi

Issue 8508059: build blob as a component (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: clean up nits Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/blob/view_blob_internals_job.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/blob/webkit_blob.gypi
diff --git a/webkit/blob/webkit_blob.gypi b/webkit/blob/webkit_blob.gypi
index 918dfb07c6cea07e4c49b1b05a13ff748b9ceb57..1b47d962f0eca94ba996c1e0fc80bd9bafeef197 100644
--- a/webkit/blob/webkit_blob.gypi
+++ b/webkit/blob/webkit_blob.gypi
@@ -6,11 +6,17 @@
'targets': [
{
'target_name': 'blob',
- 'type': 'static_library',
+ 'type': '<(component)',
'dependencies': [
'<(DEPTH)/base/base.gyp:base',
+ '<(DEPTH)/base/base.gyp:base_i18n',
+ '<(DEPTH)/base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
+ '<(DEPTH)/build/temp_gyp/googleurl.gyp:googleurl',
'<(DEPTH)/net/net.gyp:net',
],
+ 'defines': [
+ 'BLOB_IMPLEMENTATION'
+ ],
'sources': [
'blob_data.cc',
'blob_data.h',
@@ -31,6 +37,13 @@
'<(DEPTH)/webkit/support/setup_third_party.gyp:third_party_headers',
],
}],
+ # TODO(dpranke): Figure out why this works at all and/or get
+ # rid of it.
+ ['OS=="win" and component == "shared_library"', {
+ 'dependencies': [
+ '<(DEPTH)/webkit/support/webkit_support.gyp:glue',
+ ],
+ }],
],
},
],
« no previous file with comments | « webkit/blob/view_blob_internals_job.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698