Issue 8508059: build blob as a component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8508059: build blob as a component (Closed)

Created:
9 years, 1 month ago by Dirk Pranke

Modified:
9 years, 1 month ago

Reviewers:
michaeln

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

build blob as a component. This is needed to fix a failing ui_test on the linux dbg shared bot; the failure was introduced in r109534 when I enabled the component build of content. This fix isn't perfect but it should do for now. TBR=michaeln@chromium.org BUG=90442 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109589

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -10 lines)			Patch
M	webkit/blob/blob_data.h	View	1 2 3 4	3 chunks	+3 lines, -2 lines	0 comments	Download
M	webkit/blob/blob_data.cc	View	1 2 3 4 5	2 chunks	+21 lines, -2 lines	0 comments	Download
A	webkit/blob/blob_export.h	View		1 chunk	+26 lines, -0 lines	0 comments	Download
M	webkit/blob/blob_storage_controller.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/blob/blob_url_request_job.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/blob/blob_url_request_job_factory.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/blob/deletable_file_reference.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	webkit/blob/view_blob_internals_job.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/blob/webkit_blob.gypi	View	1 2 3	2 chunks	+14 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)

(hitting publish+mail so that it sends a review email)