Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 8508059: build blob as a component (Closed)

Created:
9 years, 1 month ago by Dirk Pranke
Modified:
9 years, 1 month ago
Reviewers:
michaeln
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

build blob as a component. This is needed to fix a failing ui_test on the linux dbg shared bot; the failure was introduced in r109534 when I enabled the component build of content. This fix isn't perfect but it should do for now. TBR=michaeln@chromium.org BUG=90442 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109589

Patch Set 1 #

Patch Set 2 : add gurl dependency to blob #

Patch Set 3 : export BlobData::Item #

Patch Set 4 : add conditional dependency on glue #

Patch Set 5 : fix export of BlobData::Item #

Patch Set 6 : clean up nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -10 lines) Patch
M webkit/blob/blob_data.h View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M webkit/blob/blob_data.cc View 1 2 3 4 5 2 chunks +21 lines, -2 lines 0 comments Download
A webkit/blob/blob_export.h View 1 chunk +26 lines, -0 lines 0 comments Download
M webkit/blob/blob_storage_controller.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/blob/blob_url_request_job.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/blob/blob_url_request_job_factory.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/blob/deletable_file_reference.h View 2 chunks +3 lines, -1 line 0 comments Download
M webkit/blob/view_blob_internals_job.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/blob/webkit_blob.gypi View 1 2 3 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
jam
9 years, 1 month ago (2011-11-11 17:55:14 UTC) #1
(hitting publish+mail so that it sends a review email)

Powered by Google App Engine
This is Rietveld 408576698