Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 8508051: Revert 109285 - Seems to have broken chrome_frame_net_tests on the win_rel trybot, stuffing up th... (Closed)

Created:
9 years, 1 month ago by Ryan Sleevi
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 109285 - Seems to have broken chrome_frame_net_tests on the win_rel trybot, stuffing up the CQ. Add a tray notification UI for speech input recording in the extension API. BUG=97388 TEST=existing apitests + status icon unittests Review URL: http://codereview.chromium.org/8386074 TBR=leandrogracia@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1544 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 3 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/speech/speech_input_extension_api.h View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/speech/speech_input_extension_api.cc View 1 chunk +0 lines, -172 lines 0 comments Download
D chrome/browser/speech/speech_input_extension_apitest.cc View 1 chunk +0 lines, -197 lines 0 comments Download
D chrome/browser/speech/speech_input_extension_manager.h View 1 chunk +0 lines, -196 lines 0 comments Download
D chrome/browser/speech/speech_input_extension_manager.cc View 1 chunk +0 lines, -672 lines 0 comments Download
D chrome/browser/speech/speech_input_extension_notification.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/speech/speech_input_extension_notification.cc View 1 chunk +0 lines, -154 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_api.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/experimental.speechInput.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ryan Sleevi
9 years, 1 month ago (2011-11-10 08:12:50 UTC) #1
Ryan Sleevi
Leandro, Sorry to pull a speculative revert on you, but I've been trying to track ...
9 years, 1 month ago (2011-11-10 08:17:51 UTC) #2
Ryan Sleevi
9 years, 1 month ago (2011-11-10 08:46:29 UTC) #3
Just as a warning/heads-up, drover had trouble undeleting, so I had to do it by
hand. If/when you re-land, be careful about just reverting this (r109389) - you
will minimally also need to do r109390.

You may find it easier to just use gcl patch/git cl patch with your original CL,
just wanted to make sure that you saw both, as I was unable to post a codereview
for 109390 (since gcl doesn't see an svn path copy as a valid diff)

Powered by Google App Engine
This is Rietveld 408576698