Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2083)

Unified Diff: chrome/browser/external_tab_container_win.cc

Issue 8508048: Rebase PageInfoBubble on the new views bubble. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync and merge; remove depricated code. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/external_tab_container_win.cc
diff --git a/chrome/browser/external_tab_container_win.cc b/chrome/browser/external_tab_container_win.cc
index 6e309d1794ed2232ffa9e01f460410be6e07a735..1c14be9bcccca42c3e405644d1637a35c7bad749 100644
--- a/chrome/browser/external_tab_container_win.cc
+++ b/chrome/browser/external_tab_container_win.cc
@@ -29,7 +29,6 @@
#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
#include "chrome/browser/ui/views/browser_dialogs.h"
#include "chrome/browser/ui/views/infobars/infobar_container_view.h"
-#include "chrome/browser/ui/views/page_info_bubble_view.h"
#include "chrome/browser/ui/views/tab_contents/render_view_context_menu_views.h"
#include "chrome/browser/ui/views/tab_contents/tab_contents_container.h"
#include "chrome/common/automation_messages.h"
@@ -91,35 +90,6 @@ ContextMenuModel* ConvertMenuModel(const ui::MenuModel* ui_model) {
} // namespace
-// This class overrides the LinkClicked function in the PageInfoBubbleView
-// class and routes the help center link navigation to the host browser.
-class ExternalTabPageInfoBubbleView : public PageInfoBubbleView {
- public:
- ExternalTabPageInfoBubbleView(ExternalTabContainer* container,
- gfx::NativeWindow parent_window,
- Profile* profile,
- const GURL& url,
- const NavigationEntry::SSLStatus& ssl,
- bool show_history)
- : PageInfoBubbleView(parent_window, profile, url, ssl, show_history),
- container_(container) {
- DVLOG(1) << __FUNCTION__;
- }
- virtual ~ExternalTabPageInfoBubbleView() {
- DVLOG(1) << __FUNCTION__;
- }
- // LinkListener methods:
- virtual void LinkClicked(views::Link* source, int event_flags) OVERRIDE {
- GURL url = google_util::AppendGoogleLocaleParam(
- GURL(chrome::kPageInfoHelpCenterURL));
- container_->OpenURLFromTab(container_->tab_contents(), url, GURL(),
- NEW_FOREGROUND_TAB,
- content::PAGE_TRANSITION_LINK);
- }
- private:
- scoped_refptr<ExternalTabContainer> container_;
-};
-
base::LazyInstance<ExternalTabContainer::PendingTabs>
ExternalTabContainer::pending_tabs_ = LAZY_INSTANCE_INITIALIZER;
« no previous file with comments | « no previous file | chrome/browser/ui/views/browser_dialogs.h » ('j') | chrome/browser/ui/views/page_info_bubble_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698