Do not build message_pump_x.cc when use_wayland

Do not build message_pump_x.cc when use_wayland

Change-Id: If343fbc83fdb0d0720bd7292e1db6e81188404b1

R=dnicoara@chromium.org,sadrul@chromium.org,tfarina@chromium.org
BUG=chromium:102903
TEST=compiles


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109976

[dnicoara, 2011-11-10 01:16:49]

lgtm

[sadrul, 2011-11-10 15:49:32]

You will need someone from base/OWNERS to review (evan@ and brettw@ are
currently unavailable, afaik)

http://codereview.chromium.org/8508039/diff/1/base/base.gypi
File base/base.gypi (right):

http://codereview.chromium.org/8508039/diff/1/base/base.gypi#newcode411
base/base.gypi:411: [ 'use_wayland == 1', {
I would have thought this check would be sufficient, but I suspect the inclusion
rule in 434 brings it in again? It feels like there should be a better way of
excluding the unnecessary message-pump files.

[Mandeep Singh Baines, 2011-11-11 22:44:12]

Fixed. PTAL.

Implemented a cleaner fix.

Added mark@ as a base OWNER.

Yes, the include was taking precedence over the earlier sources!. I tried moving
the wayland sources! down but message_pump_x.cc still got included.

[Mark Mentovai, 2011-11-11 22:45:52]

http://codereview.chromium.org/8508039/diff/4001/base/base.gypi
File base/base.gypi (right):

http://codereview.chromium.org/8508039/diff/4001/base/base.gypi#newcode432
base/base.gypi:432: [ 'exclude', 'message_pump_gtk.cc',],
Please specify these as proper regular expressions.

'^message_pump_gtk\.cc$'
'^message_pump_x\.cc$'

You can also fix the 'include' for message_pump_x a few lines above.

[Mandeep Singh Baines, 2011-11-11 23:09:30]

Fixed. PTAL.

[Mandeep Singh Baines, 2011-11-14 17:25:36]

ping

[sadrul, 2011-11-14 17:29:39]

LGTM

[Mandeep Singh Baines, 2011-11-14 19:26:00]

ping

Need base OWNER approval.

[Mark Mentovai, 2011-11-14 19:30:03]

LGTM

[commit-bot: I haz the power, 2011-11-14 21:47:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msb@chromium.org/8508039/5003

[commit-bot: I haz the power, 2011-11-14 23:22:10]

Change committed as 109976