Ensure that GetBootTimes is always called, since it updates histograms

chrome/browser/chromeos/login/version_info_updater.cc

Index: chrome/browser/chromeos/login/version_info_updater.cc
===================================================================
--- chrome/browser/chromeos/login/version_info_updater.cc	(revision 108130)
+++ chrome/browser/chromeos/login/version_info_updater.cc	(working copy)
@@ -50,11 +50,11 @@
         is_official_build ?
             VersionLoader::VERSION_SHORT_WITH_DATE :
             VersionLoader::VERSION_FULL);
-    if (!is_official_build) {
-      boot_times_loader_.GetBootTimes(
-          &boot_times_consumer_,
-          NewCallback(this, &VersionInfoUpdater::OnBootTimes));
-    }
+    boot_times_loader_.GetBootTimes(
+        &boot_times_consumer_,
+        NewCallback(this, is_official_build ?
+            &VersionInfoUpdater::OnBootTimesNoop :
+            &VersionInfoUpdater::OnBootTimes));

[jrbarnette, 2011/11/09 23:54:03]

It would help to have a comment here mentioning that GetBootTimes
reports statistics to UMA, so that no one need wonder why there's
a no-op callback, and so that the next developer who breaks this won't
be able to claim "I didn't know that was needed" :-).

   } else {
     UpdateVersionLabel();
   }
@@ -166,6 +166,10 @@
   UpdateVersionLabel();
 }
 
+void VersionInfoUpdater::OnBootTimesNoop(
+    BootTimesLoader::Handle handle, BootTimesLoader::BootTimes boot_times) {
+}
+
 void VersionInfoUpdater::OnBootTimes(
     BootTimesLoader::Handle handle, BootTimesLoader::BootTimes boot_times) {
   const char* kBootTimesNoChromeExec =