Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 8508015: Create a new depot_tools_testing_lib to move utility modules there (Closed)

Created:
9 years, 1 month ago by M-A Ruel
Modified:
9 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Visibility:
Public.

Description

Create a new testing_support module to move utility modules there It will simplify importing utility modules from other projects. Otherwise I was getting name conflicts with 'test'. Reenable W0403 that was disabled in the previous CL. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109636

Patch Set 1 #

Patch Set 2 : rebase against 8508017 #

Total comments: 1

Patch Set 3 : Renamed to testing_support #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1452 lines) Patch
M .gitignore View 1 1 chunk +1 line, -1 line 0 comments Download
M PRESUBMIT.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M pylintrc View 1 1 chunk +1 line, -2 lines 0 comments Download
A + testing_support/__init__.py View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + testing_support/fake_repos.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + testing_support/filesystem_mock.py View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + testing_support/local_rietveld.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
A + testing_support/patches_data.py View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + testing_support/super_mox.py View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
A + testing_support/trial_dir.py View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/breakpad_unittest.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/checkout_test.py View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
D tests/fake_repos.py View 1 chunk +0 lines, -752 lines 0 comments Download
D tests/filesystem_mock.py View 1 chunk +0 lines, -75 lines 0 comments Download
M tests/gcl_unittest.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/gclient_scm_test.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tests/gclient_smoketest.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/gclient_test.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/gclient_utils_test.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
D tests/local_rietveld.py View 1 chunk +0 lines, -153 lines 0 comments Download
M tests/owners_unittest.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M tests/patch_test.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
D tests/patches_data.py View 1 chunk +0 lines, -200 lines 0 comments Download
M tests/presubmit_unittest.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/rietveld_test.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M tests/scm_unittest.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
D tests/super_mox.py View 1 chunk +0 lines, -153 lines 0 comments Download
D tests/trial_dir.py View 1 chunk +0 lines, -97 lines 0 comments Download
M tests/trychange_unittest.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/watchlists_unittest.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
M-A Ruel
This change is dependent on http://codereview.chromium.org/8508017/ http://codereview.chromium.org/8508015/diff/2001/depot_tools_testing_lib/super_mox.py File depot_tools_testing_lib/super_mox.py (right): http://codereview.chromium.org/8508015/diff/2001/depot_tools_testing_lib/super_mox.py#newcode94 depot_tools_testing_lib/super_mox.py:94: stdout.flush = lambda: ...
9 years, 1 month ago (2011-11-09 19:13:03 UTC) #1
M-A Ruel
Note that deleting tests/__init__.py is the 'important' part of this CL so that tests isn't ...
9 years, 1 month ago (2011-11-09 19:23:23 UTC) #2
Dirk Pranke
On 2011/11/09 19:23:23, Marc-Antoine Ruel wrote: > Note that deleting tests/__init__.py is the 'important' part ...
9 years, 1 month ago (2011-11-09 23:14:46 UTC) #3
M-A Ruel
On 2011/11/09 23:14:46, Dirk Pranke wrote: > depot_tools_testing_lib is really long and redundant. How about ...
9 years, 1 month ago (2011-11-10 16:04:59 UTC) #4
Dirk Pranke
lgtm
9 years, 1 month ago (2011-11-10 20:41:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8508015/6001
9 years, 1 month ago (2011-11-11 15:39:58 UTC) #6
M-A Ruel
On 2011/11/11 15:39:58, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
9 years, 1 month ago (2011-11-11 15:49:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8508015/6001
9 years, 1 month ago (2011-11-11 15:52:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8508015/6001
9 years, 1 month ago (2011-11-11 15:59:38 UTC) #9
commit-bot: I haz the power
Change committed as 109636
9 years, 1 month ago (2011-11-11 16:06:23 UTC) #10
M-A Ruel
9 years, 1 month ago (2011-11-11 16:28:58 UTC) #11
On 2011/11/11 16:06:23, I haz the power (commit-bot) wrote:
> Change committed as 109636

Dawg, it didn't delete tests/__init__.py. I'll write a fix for that.

Powered by Google App Engine
This is Rietveld 408576698