Updated expectations.

Updated expectations.

for V8 regression, adjusted rev's.

xp-release-dual-core/moz: http://build.chromium.org/f/chromium/perf/xp-release-dual-core/moz/report.html?history=150&rev=-1&graph=vm_peak_r

Adjusted expectations for performance improvements from skia roll.

xp-release-dual-core/moz: http://build.chromium.org/f/chromium/perf/xp-release-dual-core/moz/report.html?history=150&rev=109265&graph=total_byte_r

xp-release-dual-core/moz: http://build.chromium.org/f/chromium/perf/xp-release-dual-core/moz/report.html?history=150&rev=109265&graph=total_op_r


BUG=103586, 103454
TBR=cmp
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109277

[cmp, 2011-11-09 19:28:37]

http://codereview.chromium.org/8507014/diff/1/tools/perf_expectations/perf_ex...
File tools/perf_expectations/perf_expectations.json (right):

http://codereview.chromium.org/8507014/diff/1/tools/perf_expectations/perf_ex...
tools/perf_expectations/perf_expectations.json:102:
"xp-release-dual-core/moz/total_byte_r/IO_r": {"reva": 109227, "revb": 109265,
"improve": 307, "regress": 473, "sha1": "4654bbef"},
for reva, 109227 is okay, 109228 would be better (to line up with the graph)
for revb, 109265 will cause the result at 109266 to be excluded, so it would be
better to use 109266

http://codereview.chromium.org/8507014/diff/1/tools/perf_expectations/perf_ex...
tools/perf_expectations/perf_expectations.json:104:
"xp-release-dual-core/moz/total_op_r/IO_op_r": {"reva": 109227, "revb": 109265,
"improve": 1674, "regress": 2364, "sha1": "bd37744c"},
same as above

http://codereview.chromium.org/8507014/diff/1/tools/perf_expectations/perf_ex...
tools/perf_expectations/perf_expectations.json:106:
"xp-release-dual-core/moz/vm_peak_r/vm_pk_r": {"reva": 108861, "revb": 109262,
"improve": 5498265, "regress": 7840359, "sha1": "230f1c5a"},
sha1 should have been updated, and maybe improve+regress too

after you changed reva on this line, did you definitely run make_expectations.py
again?

[ramant (doing other things), 2011-11-09 19:46:09]

http://codereview.chromium.org/8507014/diff/1/tools/perf_expectations/perf_ex...
File tools/perf_expectations/perf_expectations.json (right):

http://codereview.chromium.org/8507014/diff/1/tools/perf_expectations/perf_ex...
tools/perf_expectations/perf_expectations.json:102:
"xp-release-dual-core/moz/total_byte_r/IO_r": {"reva": 109227, "revb": 109265,
"improve": 307, "regress": 473, "sha1": "4654bbef"},
On 2011/11/09 19:28:37, cmp wrote:
> for reva, 109227 is okay, 109228 would be better (to line up with the graph)
> for revb, 109265 will cause the result at 109266 to be excluded, so it would
be
> better to use 109266

http://codereview.chromium.org/8508022/

Done.

http://codereview.chromium.org/8507014/diff/1/tools/perf_expectations/perf_ex...
tools/perf_expectations/perf_expectations.json:104:
"xp-release-dual-core/moz/total_op_r/IO_op_r": {"reva": 109227, "revb": 109265,
"improve": 1674, "regress": 2364, "sha1": "bd37744c"},
On 2011/11/09 19:28:37, cmp wrote:
> same as above

http://codereview.chromium.org/8508022/

Done.

http://codereview.chromium.org/8507014/diff/1/tools/perf_expectations/perf_ex...
tools/perf_expectations/perf_expectations.json:106:
"xp-release-dual-core/moz/vm_peak_r/vm_pk_r": {"reva": 108861, "revb": 109262,
"improve": 5498265, "regress": 7840359, "sha1": "230f1c5a"},
On 2011/11/09 19:28:37, cmp wrote:
> sha1 should have been updated, and maybe improve+regress too
> 
> after you changed reva on this line, did you definitely run
make_expectations.py
> again?

http://codereview.chromium.org/8508022/

Done.

[cmp, 2011-11-09 19:50:06]

lgtm