Chromium Code Reviews| Index: src/platform-linux.cc |
| diff --git a/src/platform-linux.cc b/src/platform-linux.cc |
| index 90f45dd163a22efc39e9a45d13bc70a91f892edc..ebd3a682d7f8da0b73dd2d2595ef70cdcd912239 100644 |
| --- a/src/platform-linux.cc |
| +++ b/src/platform-linux.cc |
| @@ -964,7 +964,6 @@ static int GetThreadID() { |
| static void ProfilerSignalHandler(int signal, siginfo_t* info, void* context) { |
| -#ifndef V8_HOST_ARCH_MIPS |
| USE(info); |
| if (signal != SIGPROF) return; |
| Isolate* isolate = Isolate::UncheckedCurrent(); |
| @@ -1008,13 +1007,12 @@ static void ProfilerSignalHandler(int signal, siginfo_t* info, void* context) { |
| sample->fp = reinterpret_cast<Address>(mcontext.arm_fp); |
| #endif |
| #elif V8_HOST_ARCH_MIPS |
|
mnaganov (inactive)
2011/11/09 11:26:22
Does it compile at all? Looks simply incorrect as
Yang
2011/11/09 11:36:05
I think this #elif refers to the #if V8_HOST_ARCH_
mnaganov (inactive)
2011/11/09 11:49:42
Ah, that's right. I'd recommend adding a comment l
|
| - sample.pc = reinterpret_cast<Address>(mcontext.pc); |
| - sample.sp = reinterpret_cast<Address>(mcontext.gregs[29]); |
| - sample.fp = reinterpret_cast<Address>(mcontext.gregs[30]); |
| + sample->pc = reinterpret_cast<Address>(mcontext.pc); |
| + sample->sp = reinterpret_cast<Address>(mcontext.gregs[29]); |
| + sample->fp = reinterpret_cast<Address>(mcontext.gregs[30]); |
| #endif |
| sampler->SampleStack(sample); |
| sampler->Tick(sample); |
| -#endif |
| } |