Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 8506027: build sql as a component - this will help ensure there is only one copy (Closed)

Created:
9 years, 1 month ago by Dirk Pranke
Modified:
9 years, 1 month ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Visibility:
Public.

Description

build sql as a component - this will help ensure there is only one copy of sqlite getting linked in. R=rsesek@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109510

Patch Set 1 #

Patch Set 2 : don't export DiagnosticErrorDelegate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -6 lines) Patch
M sql/connection.h View 3 chunks +3 lines, -2 lines 0 comments Download
M sql/diagnostic_error_delegate.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M sql/meta_table.h View 1 chunk +2 lines, -1 line 0 comments Download
M sql/sql.gyp View 1 chunk +2 lines, -1 line 0 comments Download
A sql/sql_export.h View 1 chunk +26 lines, -0 lines 0 comments Download
M sql/statement.h View 2 chunks +2 lines, -1 line 0 comments Download
M sql/transaction.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Dirk Pranke
9 years, 1 month ago (2011-11-09 21:09:46 UTC) #1
Robert Sesek
9 years, 1 month ago (2011-11-09 21:31:03 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698