Issue 8506020: Fixing test cases for correct assertSame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8506020: Fixing test cases for correct assertSame. (Closed)

Created:
9 years, 1 month ago by rossberg

Modified:
9 years, 1 month ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fixing test cases for correct assertSame. Leaving out derived construct trap for now, which I'm working on separately. R=mstarzinger@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9960

Patch Set 1 #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -16 lines)			Patch
M	src/v8natives.js	View	1 chunk	+3 lines, -5 lines	2 comments	Download
M	test/mjsunit/harmony/proxies-function.js	View	5 chunks	+13 lines, -10 lines	0 comments	Download
M	test/mjsunit/mjsunit.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with nits). http://codereview.chromium.org/8506020/diff/1/src/v8natives.js File src/v8natives.js (right): http://codereview.chromium.org/8506020/diff/1/src/v8natives.js#newcode1056 src/v8natives.js:1056: obj.length = 0; I'm fine with ...

9 years, 1 month ago (2011-11-10 14:20:00 UTC) #2

rossberg

9 years, 1 month ago (2011-11-10 15:20:23 UTC) #3

http://codereview.chromium.org/8506020/diff/1/src/v8natives.js
File src/v8natives.js (right):

http://codereview.chromium.org/8506020/diff/1/src/v8natives.js#newcode1056
src/v8natives.js:1056: obj.length = 0;
On 2011/11/10 14:20:00, Michael Starzinger wrote:
> I'm fine with this hack for now. But can you please file a bug-report stating
> that we have a general problem when Object.defineProperty() is invoked on a
> Function object for the "length" (and maybe the "prototype") property. And
also
> add a comment here referring to the bug number.

There is a bug already, see:

http://code.google.com/p/v8/issues/detail?id=1530

Expand Messages | Collapse Messages