WebUI TaskManager: Add "Activate page" feature.

WebUI TaskManager: Add "Activate page" feature.

Web can activate a page by double-clicking on the page or the context-menu.

BUG=103345
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109394

[mazda, 2011-11-09 07:16:14]

http://codereview.chromium.org/8506003/diff/1/chrome/browser/resources/task_m...
File chrome/browser/resources/task_manager/main.js (right):

http://codereview.chromium.org/8506003/diff/1/chrome/browser/resources/task_m...
chrome/browser/resources/task_manager/main.js:287: item.textContent
item.textContent = localized_label || default_label;

http://codereview.chromium.org/8506003/diff/1/chrome/browser/resources/task_m...
chrome/browser/resources/task_manager/main.js:427: } else if
(command.id.substr(0, 17) == 'tableContextMenu-') {
Please make a constant variable for 'tableContextMenu-' (and
'columnContextMenu-' as well) and avoid using magic numbers.

http://codereview.chromium.org/8506003/diff/1/chrome/browser/resources/task_m...
chrome/browser/resources/task_manager/main.js:431: if (target_unique_id) {
if (!target_unique_id)
  return;

if (sub_command = ...

[yoshiki, 2011-11-10 05:09:47]

http://codereview.chromium.org/8506003/diff/1/chrome/browser/resources/task_m...
File chrome/browser/resources/task_manager/main.js (right):

http://codereview.chromium.org/8506003/diff/1/chrome/browser/resources/task_m...
chrome/browser/resources/task_manager/main.js:287: item.textContent
On 2011/11/09 07:16:14, mazda wrote:
> item.textContent = localized_label || default_label;

Done.

http://codereview.chromium.org/8506003/diff/1/chrome/browser/resources/task_m...
chrome/browser/resources/task_manager/main.js:427: } else if
(command.id.substr(0, 17) == 'tableContextMenu-') {
On 2011/11/09 07:16:14, mazda wrote:
> Please make a constant variable for 'tableContextMenu-' (and
> 'columnContextMenu-' as well) and avoid using magic numbers.

Done.

http://codereview.chromium.org/8506003/diff/1/chrome/browser/resources/task_m...
chrome/browser/resources/task_manager/main.js:431: if (target_unique_id) {
On 2011/11/09 07:16:14, mazda wrote:
> if (!target_unique_id)
>   return;
> 
> if (sub_command = ...

Done.

[mazda, 2011-11-10 05:32:26]

http://codereview.chromium.org/8506003/diff/4001/chrome/browser/resources/tas...
File chrome/browser/resources/task_manager/main.js (right):

http://codereview.chromium.org/8506003/diff/4001/chrome/browser/resources/tas...
chrome/browser/resources/task_manager/main.js:428: ==
COMMAND_CONTEXTMENU_COLUMN_PREFIX) {
I think it's more common to put operator at the end of the line instead of the
beginning.

http://codereview.chromium.org/8506003/diff/4001/chrome/browser/resources/tas...
chrome/browser/resources/task_manager/main.js:429:
console.log(command.id.substr(18));
18 -> COMMAND_CONTEXTMENU_COLUMN_PREFIX.length

http://codereview.chromium.org/8506003/diff/4001/chrome/browser/resources/tas...
chrome/browser/resources/task_manager/main.js:432: ==
COMMAND_CONTEXTMENU_TABLE_PREFIX) {
Operator position.

http://codereview.chromium.org/8506003/diff/4001/chrome/browser/resources/tas...
chrome/browser/resources/task_manager/main.js:434: var sub_command =
command.id.substr(17);
17 -> COMMAND_CONTEXTMENU_TABLE_PREFIX.length

http://codereview.chromium.org/8506003/diff/4001/chrome/browser/resources/tas...
chrome/browser/resources/task_manager/main.js:459: =
mc[COMMAND_CONTEXTMENU_TABLE_PREFIX + 'inspect'].menuitem;
Operator position.

http://codereview.chromium.org/8506003/diff/4001/chrome/browser/resources/tas...
chrome/browser/resources/task_manager/main.js:461: =
mc[COMMAND_CONTEXTMENU_TABLE_PREFIX + 'activate'].menuitem;
Operator position.

[yoshiki, 2011-11-10 08:15:01]

http://codereview.chromium.org/8506003/diff/4001/chrome/browser/resources/tas...
File chrome/browser/resources/task_manager/main.js (right):

http://codereview.chromium.org/8506003/diff/4001/chrome/browser/resources/tas...
chrome/browser/resources/task_manager/main.js:428: ==
COMMAND_CONTEXTMENU_COLUMN_PREFIX) {
Stop substr()-based implement and change to 1 line.

On 2011/11/10 05:32:26, mazda wrote:
> I think it's more common to put operator at the end of the line instead of the
> beginning.

http://codereview.chromium.org/8506003/diff/4001/chrome/browser/resources/tas...
chrome/browser/resources/task_manager/main.js:429:
console.log(command.id.substr(18));
ditto

On 2011/11/10 05:32:26, mazda wrote:
> 18 -> COMMAND_CONTEXTMENU_COLUMN_PREFIX.length

http://codereview.chromium.org/8506003/diff/4001/chrome/browser/resources/tas...
chrome/browser/resources/task_manager/main.js:432: ==
COMMAND_CONTEXTMENU_TABLE_PREFIX) {
ditto

On 2011/11/10 05:32:26, mazda wrote:
> Operator position.

http://codereview.chromium.org/8506003/diff/4001/chrome/browser/resources/tas...
chrome/browser/resources/task_manager/main.js:434: var sub_command =
command.id.substr(17);
ditto

On 2011/11/10 05:32:26, mazda wrote:
> 17 -> COMMAND_CONTEXTMENU_TABLE_PREFIX.length

http://codereview.chromium.org/8506003/diff/4001/chrome/browser/resources/tas...
chrome/browser/resources/task_manager/main.js:459: =
mc[COMMAND_CONTEXTMENU_TABLE_PREFIX + 'inspect'].menuitem;
On 2011/11/10 05:32:26, mazda wrote:
> Operator position.

Done.

http://codereview.chromium.org/8506003/diff/4001/chrome/browser/resources/tas...
chrome/browser/resources/task_manager/main.js:461: =
mc[COMMAND_CONTEXTMENU_TABLE_PREFIX + 'activate'].menuitem;
On 2011/11/10 05:32:26, mazda wrote:
> Operator position.

Done.

[mazda, 2011-11-10 08:20:11]

lgtm

[commit-bot: I haz the power, 2011-11-10 08:22:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/8506003/6002

[commit-bot: I haz the power, 2011-11-10 09:02:46]

Try job failure for 8506003-6002 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...