Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 8506002: NaCl: Re-enable run_ppapi_example_font_test (Closed)

Created:
9 years, 1 month ago by Mark Seaborn
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

NaCl: Re-enable run_ppapi_example_font_test This test was failing in the debug build of Chromium when I was enabling NaCl tests on Mac OS X the other month. It now seems to be passing, so let's enable it. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2077 TEST=nacl_integration Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109582

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/test/nacl_test_injection/buildbot_nacl_integration.py View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mark Seaborn
9 years, 1 month ago (2011-11-09 06:28:28 UTC) #1
Nick Bray
LGTM - but explain why it's OK to reenable in commit message.
9 years, 1 month ago (2011-11-10 18:36:45 UTC) #2
Nick Bray (chromium)
On 2011/11/10 18:36:45, Nick Bray wrote: > LGTM - but explain why it's OK to ...
9 years, 1 month ago (2011-11-10 18:37:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/8506002/1
9 years, 1 month ago (2011-11-11 01:49:35 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
9 years, 1 month ago (2011-11-11 02:52:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/8506002/1
9 years, 1 month ago (2011-11-11 02:55:48 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-11-11 04:11:11 UTC) #7
Change committed as 109582

Powered by Google App Engine
This is Rietveld 408576698