Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: runtime/vm/class_finalizer_test.cc

Issue 8506001: Finalize all classes (fix issue 364). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/assert.h" 5 #include "vm/assert.h"
6 #include "vm/class_finalizer.h" 6 #include "vm/class_finalizer.h"
7 #include "vm/unit_test.h" 7 #include "vm/unit_test.h"
8 8
9 namespace dart { 9 namespace dart {
10 10
11 11
12 static RawClass* CreateTestClass(const char* name) { 12 static RawClass* CreateTestClass(const char* name) {
13 const Array& empty_array = Array::Handle(Array::Empty()); 13 const Array& empty_array = Array::Handle(Array::Empty());
14 const String& class_name = String::Handle(String::NewSymbol(name)); 14 const String& class_name = String::Handle(String::NewSymbol(name));
15 const Script& script = Script::Handle(); 15 const Script& script = Script::Handle();
16 const Class& cls = Class::Handle(Class::New(class_name, script)); 16 const Class& cls = Class::Handle(Class::New(class_name, script));
17 cls.set_interfaces(empty_array); 17 cls.set_interfaces(empty_array);
18 cls.SetFunctions(empty_array); 18 cls.SetFunctions(empty_array);
19 cls.SetFields(empty_array); 19 cls.SetFields(empty_array);
20 return cls.raw(); 20 return cls.raw();
21 } 21 }
22 22
23 23
24 TEST_CASE(ClassFinalizer) { 24 TEST_CASE(ClassFinalizer) {
25 ClassFinalizer::ExpectPendingClasses();
25 GrowableArray<const Class*> classes_1; 26 GrowableArray<const Class*> classes_1;
26 classes_1.Add(&Class::ZoneHandle(CreateTestClass("BMW"))); 27 classes_1.Add(&Class::ZoneHandle(CreateTestClass("BMW")));
27 classes_1.Add(&Class::ZoneHandle(CreateTestClass("Porsche"))); 28 classes_1.Add(&Class::ZoneHandle(CreateTestClass("Porsche")));
28 ClassFinalizer::AddPendingClasses(classes_1); 29 ClassFinalizer::AddPendingClasses(classes_1);
29 GrowableArray<const Class*> classes_2; 30 GrowableArray<const Class*> classes_2;
30 classes_2.Add(&Class::ZoneHandle(CreateTestClass("Ferrari"))); 31 classes_2.Add(&Class::ZoneHandle(CreateTestClass("Ferrari")));
31 classes_2.Add(&Class::ZoneHandle(CreateTestClass("Fiat"))); 32 classes_2.Add(&Class::ZoneHandle(CreateTestClass("Fiat")));
32 classes_2.Add(&Class::ZoneHandle(CreateTestClass("Alfa"))); 33 classes_2.Add(&Class::ZoneHandle(CreateTestClass("Alfa")));
33 ClassFinalizer::AddPendingClasses(classes_2); 34 ClassFinalizer::AddPendingClasses(classes_2);
34 EXPECT(ClassFinalizer::FinalizePendingClasses()); 35 EXPECT(ClassFinalizer::FinalizePendingClasses());
35 for (int i = 0; i < classes_1.length(); i++) { 36 for (int i = 0; i < classes_1.length(); i++) {
36 EXPECT(classes_1[i]->is_finalized()); 37 EXPECT(classes_1[i]->is_finalized());
37 } 38 }
38 for (int i = 0; i < classes_2.length(); i++) { 39 for (int i = 0; i < classes_2.length(); i++) {
39 EXPECT(classes_2[i]->is_finalized()); 40 EXPECT(classes_2[i]->is_finalized());
40 } 41 }
41 EXPECT(ClassFinalizer::FinalizePendingClasses()); 42 EXPECT(ClassFinalizer::FinalizePendingClasses());
42 } 43 }
43 44
44 45
45 TEST_CASE(ClassFinalize_Cycles) { 46 TEST_CASE(ClassFinalize_Cycles) {
47 ClassFinalizer::ExpectPendingClasses();
46 GrowableArray<const Class*> classes; 48 GrowableArray<const Class*> classes;
47 classes.Add(&Class::ZoneHandle(CreateTestClass("Jungfrau"))); 49 classes.Add(&Class::ZoneHandle(CreateTestClass("Jungfrau")));
48 classes.Add(&Class::ZoneHandle(CreateTestClass("Eiger"))); 50 classes.Add(&Class::ZoneHandle(CreateTestClass("Eiger")));
49 // Create a cycle. 51 // Create a cycle.
50 classes[0]->set_super_type( 52 classes[0]->set_super_type(
51 Type::Handle(Type::NewNonParameterizedType(*classes[1]))); 53 Type::Handle(Type::NewNonParameterizedType(*classes[1])));
52 classes[1]->set_super_type( 54 classes[1]->set_super_type(
53 Type::Handle(Type::NewNonParameterizedType(*classes[0]))); 55 Type::Handle(Type::NewNonParameterizedType(*classes[0])));
54 ClassFinalizer::AddPendingClasses(classes); 56 ClassFinalizer::AddPendingClasses(classes);
55 EXPECT(!ClassFinalizer::FinalizePendingClasses()); 57 EXPECT(!ClassFinalizer::FinalizePendingClasses());
56 } 58 }
57 59
58 60
59 static RawLibrary* NewLib(const char* url_chars) { 61 static RawLibrary* NewLib(const char* url_chars) {
60 String& url = String::ZoneHandle(String::NewSymbol(url_chars)); 62 String& url = String::ZoneHandle(String::NewSymbol(url_chars));
61 return Library::New(url); 63 return Library::New(url);
62 } 64 }
63 65
64 66
65 TEST_CASE(ClassFinalize_Resolve) { 67 TEST_CASE(ClassFinalize_Resolve) {
68 ClassFinalizer::ExpectPendingClasses();
66 GrowableArray<const Class*> classes; 69 GrowableArray<const Class*> classes;
67 Class& rhb = Class::ZoneHandle(CreateTestClass("RhB")); 70 Class& rhb = Class::ZoneHandle(CreateTestClass("RhB"));
68 Class& sbb = Class::ZoneHandle(CreateTestClass("SBB")); 71 Class& sbb = Class::ZoneHandle(CreateTestClass("SBB"));
69 Library& lib = Library::Handle(NewLib("TestLib")); 72 Library& lib = Library::Handle(NewLib("TestLib"));
70 classes.Add(&rhb); 73 classes.Add(&rhb);
71 classes.Add(&sbb); 74 classes.Add(&sbb);
72 lib.AddClass(rhb); 75 lib.AddClass(rhb);
73 lib.AddClass(sbb); 76 lib.AddClass(sbb);
74 const String& superclass_name = String::Handle(sbb.Name()); 77 const String& superclass_name = String::Handle(sbb.Name());
75 const UnresolvedClass& unresolved = UnresolvedClass::Handle( 78 const UnresolvedClass& unresolved = UnresolvedClass::Handle(
76 UnresolvedClass::New(0, String::Handle(), superclass_name)); 79 UnresolvedClass::New(0, String::Handle(), superclass_name));
77 TypeArguments& type_arguments = TypeArguments::Handle(); 80 TypeArguments& type_arguments = TypeArguments::Handle();
78 rhb.set_super_type(Type::Handle(Type::NewParameterizedType( 81 rhb.set_super_type(Type::Handle(Type::NewParameterizedType(
79 Object::Handle(unresolved.raw()), type_arguments))); 82 Object::Handle(unresolved.raw()), type_arguments)));
80 ClassFinalizer::AddPendingClasses(classes); 83 ClassFinalizer::AddPendingClasses(classes);
81 EXPECT(ClassFinalizer::FinalizePendingClasses()); 84 EXPECT(ClassFinalizer::FinalizePendingClasses());
82 } 85 }
83 86
84 } // namespace dart 87 } // namespace dart
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698