chrome/browser/ui/panels/base_panel_browser_test.cc - Issue 8505047: Fix panels being removed from PanelManager prematurely.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/base_panel_browser_test.cc

Issue 8505047: Fix panels being removed from PanelManager prematurely. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Change test from using notification to timeout. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/panels/base_panel_browser_test.cc

diff --git a/chrome/browser/ui/panels/base_panel_browser_test.cc b/chrome/browser/ui/panels/base_panel_browser_test.cc

index 992557bd1f9211e7ebcc3d240ab10b9032428804..fd369628b5458d27cdc4211d0c9723b3e403665f 100644

--- a/chrome/browser/ui/panels/base_panel_browser_test.cc

+++ b/chrome/browser/ui/panels/base_panel_browser_test.cc

@@ -10,12 +10,14 @@

#include "base/command_line.h"

#include "base/memory/weak_ptr.h"

#include "base/message_loop.h"

+#include "base/path_service.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/panels/native_panel.h"

#include "chrome/browser/ui/panels/panel_manager.h"

#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"

+#include "chrome/common/chrome_paths.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/test/base/ui_test_utils.h"

#include "content/browser/tab_contents/test_tab_contents.h"

@@ -169,6 +171,9 @@ BasePanelBrowserTest::~BasePanelBrowserTest() {

void BasePanelBrowserTest::SetUpCommandLine(CommandLine* command_line) {

EnableDOMAutomation();

+ PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir_);

+ test_data_dir_ = test_data_dir_.AppendASCII("panels");

}

void BasePanelBrowserTest::SetUpOnMainThread() {