content/browser/renderer_host/render_view_host.cc - Issue 8505047: Fix panels being removed from PanelManager prematurely.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host.cc

Issue 8505047: Fix panels being removed from PanelManager prematurely. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Got rid of timeout by adding Details to notification from RenderViewHost. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_view_host.cc

diff --git a/content/browser/renderer_host/render_view_host.cc b/content/browser/renderer_host/render_view_host.cc

index 2228aafe6b265184c790b02f53650a155ab5bebc..5e27a8a75ac2ae486bd16b3cb49602f0228db5e8 100644

--- a/content/browser/renderer_host/render_view_host.cc

+++ b/content/browser/renderer_host/render_view_host.cc

@@ -1167,6 +1167,10 @@ void RenderViewHost::OnMsgShouldCloseACK(bool proceed) {

return;

is_waiting_for_beforeunload_ack_ = false;

+ content::NotificationService::current()->Notify(

+ content::NOTIFICATION_RENDER_VIEW_HOST_RECEIVED_ON_MSG_SHOULD_CLOSE_ACK,

+ content::Source<RenderViewHost>(this),

+ content::Details<bool>(&proceed));

RenderViewHostDelegate::RendererManagement* management_delegate =

delegate_->GetRendererManagementDelegate();