Fix panels being removed from PanelManager prematurely.

chrome/browser/ui/panels/panel_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/download/download_service.h"
 #include "chrome/browser/download/download_service_factory.h"
 #include "chrome/browser/net/url_request_mock_util.h"
 #include "chrome/browser/notifications/balloon_collection_impl.h"
 #include "chrome/browser/notifications/desktop_notification_service.h"
 #include "chrome/browser/notifications/notification.h"
 #include "chrome/browser/notifications/notification_ui_manager.h"
 #include "chrome/browser/prefs/browser_prefs.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/app_modal_dialogs/app_modal_dialog.h"
+#include "chrome/browser/ui/app_modal_dialogs/native_app_modal_dialog.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/find_bar/find_bar.h"
 #include "chrome/browser/ui/find_bar/find_bar_controller.h"
 #include "chrome/browser/ui/panels/base_panel_browser_test.h"
 #include "chrome/browser/ui/panels/native_panel.h"
 #include "chrome/browser/ui/panels/panel.h"
 #include "chrome/browser/ui/panels/panel_manager.h"
 #include "chrome/browser/ui/panels/panel_settings_menu_model.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/browser/download/download_manager.h"
 #include "content/browser/net/url_request_mock_http_job.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "content/common/desktop_notification_messages.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/common/url_constants.h"
+#include "net/base/net_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gfx/screen.h"
 
 using content::BrowserThread;
 
 class PanelBrowserTest : public BasePanelBrowserTest {
  public:
   PanelBrowserTest() : BasePanelBrowserTest() {
   }
 
@@ skipping 1344 matching lines @@
 
   // Wait for the panels opened by the first extension to close.
   signal.Wait();
   signal1.Wait();
 
   // Verify that the panel that's left is the panel from the second extension.
   EXPECT_EQ(panel_other, panel_manager->panels()[0]);
   panel_other->Close();
 }
 
+IN_PROC_BROWSER_TEST_F(PanelBrowserTest, OnBeforeUnloadOnClose) {
+  PanelManager* panel_manager = PanelManager::GetInstance();
+  EXPECT_EQ(0, panel_manager->num_panels()); // No panels initially.
+
+  const char* on_before_unload_html_file = "onbeforeunload.html";
+  const string16 title_first_close = UTF8ToUTF16("TitleFirstClose");
+  const string16 title_second_close = UTF8ToUTF16("TitleSecondClose");
+
+  // Create a test panel with tab contents loaded.
+  CreatePanelParams params("PanelTest1", gfx::Rect(0, 0, 300, 300),
+                           SHOW_AS_ACTIVE);
+  params.url = GURL(net::FilePathToFileURL(
+      test_data_dir_.AppendASCII(on_before_unload_html_file)));
+  Panel* panel = CreatePanelWithParams(params);
+  EXPECT_EQ(1, panel_manager->num_panels());
+  TabContents* tab_contents = panel->browser()->GetSelectedTabContents();
+
+  // Close panel and respond to the onbeforeunload dialog with cancel. This is
+  // equivalent to clicking "Stay on this page"
+  scoped_ptr<ui_test_utils::TitleWatcher> title_watcher(
+      new ui_test_utils::TitleWatcher(tab_contents, title_first_close));
+  panel->Close();
+  AppModalDialog* alert = ui_test_utils::WaitForAppModalDialog();
+  alert->native_dialog()->CancelAppModalDialog();
+  EXPECT_EQ(title_first_close, title_watcher->WaitAndGetTitle());
+  EXPECT_EQ(1, panel_manager->num_panels());
+
+  // Close panel and respond to the onbeforeunload dialog with close. This is
+  // equivalent to clicking the OS close button on the dialog.
+  title_watcher.reset(
+      new ui_test_utils::TitleWatcher(tab_contents, title_second_close));
+  panel->Close();
+  alert = ui_test_utils::WaitForAppModalDialog();
+  alert->native_dialog()->CloseAppModalDialog();
+  EXPECT_EQ(title_second_close, title_watcher->WaitAndGetTitle());
+  EXPECT_EQ(1, panel_manager->num_panels());
+
+  // Close panel and respond to the onbeforeunload dialog with accept. This is
+  // equivalent to clicking "Leave this page".
+  ui_test_utils::WindowedNotificationObserver browser_closed(
+      chrome::NOTIFICATION_BROWSER_CLOSED,
+      content::Source<Browser>(panel->browser()));
+  panel->Close();
+  alert = ui_test_utils::WaitForAppModalDialog();
+  alert->native_dialog()->AcceptAppModalDialog();
+  browser_closed.Wait();
+  EXPECT_EQ(0, panel_manager->num_panels());
+}
+
 class PanelDownloadTest : public PanelBrowserTest {
  public:
   PanelDownloadTest() : PanelBrowserTest() { }
 
   // Creates a temporary directory for downloads that is auto-deleted
   // on destruction.
   bool CreateDownloadDirectory(Profile* profile) {
     bool created = downloads_directory_.CreateUniqueTempDir();
     if (!created)
       return false;
@@ skipping 305 matching lines @@
   // the same position when short panel is first created.
   panel1->SetExpansionState(Panel::EXPANDED);
   WaitForBoundsAnimationFinished(panel1);
   int balloon_bottom_after_short_panel_expanded =
       GetBalloonBottomPosition(balloon);
   EXPECT_EQ(balloon_bottom_after_short_panel_created,
             balloon_bottom_after_short_panel_expanded);
 
   // Closing short panel should move the notification balloon down to the same
   // position when tall panel brings up its titlebar.
-  panel1->Close();
-  WaitForBoundsAnimationFinished(panel1);
+  CloseWindowAndWait(panel1->browser());
   EXPECT_EQ(balloon_bottom_after_tall_panel_titlebar_up,
             GetBalloonBottomPosition(balloon));
 
   // Closing the remaining tall panel should move the notification balloon back
   // to its original position.
-  panel2->Close();
-  WaitForBoundsAnimationFinished(panel2);
+  CloseWindowAndWait(panel2->browser());
   EXPECT_EQ(original_balloon_bottom, GetBalloonBottomPosition(balloon));
 }